Title: [159090] trunk/Source/WebKit2
Revision
159090
Author
g...@gnome.org
Date
2013-11-11 17:55:35 -0800 (Mon, 11 Nov 2013)

Log Message

REGRESSION(r158976): Web Inspector: unable to start docked or dock
https://bugs.webkit.org/show_bug.cgi?id=124148

Reviewed by Timothy Hatcher.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::canAttach): check for a level that is greater than 1 rather than 0
to deny attachment, since 1 is the first level of inspectors.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (159089 => 159090)


--- trunk/Source/WebKit2/ChangeLog	2013-11-12 01:51:39 UTC (rev 159089)
+++ trunk/Source/WebKit2/ChangeLog	2013-11-12 01:55:35 UTC (rev 159090)
@@ -1,3 +1,14 @@
+2013-11-11  Gustavo Noronha Silva  <g...@gnome.org>
+
+        REGRESSION(r158976): Web Inspector: unable to start docked or dock
+        https://bugs.webkit.org/show_bug.cgi?id=124148
+
+        Reviewed by Timothy Hatcher.
+
+        * UIProcess/WebInspectorProxy.cpp:
+        (WebKit::WebInspectorProxy::canAttach): check for a level that is greater than 1 rather than 0
+        to deny attachment, since 1 is the first level of inspectors.
+
 2013-11-11  Anders Carlsson  <ander...@apple.com>
 
         FrameFilter can just be an std::function instead

Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp (159089 => 159090)


--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp	2013-11-12 01:51:39 UTC (rev 159089)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp	2013-11-12 01:55:35 UTC (rev 159090)
@@ -549,7 +549,7 @@
         return true;
 
     // Don't allow attaching to another inspector -- two inspectors in one window is too much!
-    if (m_level > 0)
+    if (m_level > 1)
         return false;
 
     // Don't allow the attach if the window would be too small to accommodate the minimum inspector height.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to