Modified: trunk/Source/WebCore/ChangeLog (159092 => 159093)
--- trunk/Source/WebCore/ChangeLog 2013-11-12 04:39:34 UTC (rev 159092)
+++ trunk/Source/WebCore/ChangeLog 2013-11-12 04:39:59 UTC (rev 159093)
@@ -1,3 +1,12 @@
+2013-11-11 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Remove some unused generated code
+ https://bugs.webkit.org/show_bug.cgi?id=124179
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/CodeGeneratorInspectorStrings.py:
+
2013-11-11 Gyuyoung Kim <[email protected]>
Clean up static_cast<Element*> usage
Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspectorStrings.py (159092 => 159093)
--- trunk/Source/WebCore/inspector/CodeGeneratorInspectorStrings.py 2013-11-12 04:39:34 UTC (rev 159092)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspectorStrings.py 2013-11-12 04:39:59 UTC (rev 159093)
@@ -33,9 +33,8 @@
""" class $domainClassName {
public:
$domainClassName(InspectorFrontendChannel* inspectorFrontendChannel) : m_inspectorFrontendChannel(inspectorFrontendChannel) { }
-${frontendDomainMethodDeclarations} void setInspectorFrontendChannel(InspectorFrontendChannel* inspectorFrontendChannel) { m_inspectorFrontendChannel = inspectorFrontendChannel; }
- InspectorFrontendChannel* getInspectorFrontendChannel() { return m_inspectorFrontendChannel; }
- private:
+${frontendDomainMethodDeclarations}
+ protected:
InspectorFrontendChannel* m_inspectorFrontendChannel;
};
@@ -67,8 +66,8 @@
{
RefPtr<InspectorObject> jsonMessage = InspectorObject::create();
jsonMessage->setString("method", "$domainName.$eventName");
-$code if (m_inspectorFrontendChannel)
- m_inspectorFrontendChannel->sendMessageToFrontend(jsonMessage->toJSONString());
+$code
+ m_inspectorFrontendChannel->sendMessageToFrontend(jsonMessage->toJSONString());
}
""")
@@ -182,7 +181,6 @@
void reportProtocolError(const long* const callId, CommonErrorCode, const String& errorMessage) const;
virtual void reportProtocolError(const long* const callId, CommonErrorCode, const String& errorMessage, PassRefPtr<InspectorArray> data) const = 0;
virtual void dispatch(const String& message) = 0;
- static bool getCommandName(const String& message, String* result);
enum MethodNames {
$methodNamesEnumContent
@@ -460,22 +458,6 @@
return getPropertyValueImpl<PassRefPtr<InspectorArray>, RefPtr<InspectorArray>, InspectorArray*>(object, name, valueFound, protocolErrors, 0, AsMethodBridges::asArray, "Array");
}
-bool InspectorBackendDispatcher::getCommandName(const String& message, String* result)
-{
- RefPtr<InspectorValue> value = InspectorValue::parseJSON(message);
- if (!value)
- return false;
-
- RefPtr<InspectorObject> object = value->asObject();
- if (!object)
- return false;
-
- if (!object->getString("method", result))
- return false;
-
- return true;
-}
-
InspectorBackendDispatcher::CallbackBase::CallbackBase(PassRefPtr<InspectorBackendDispatcherImpl> backendImpl, int id)
: m_backendImpl(backendImpl), m_id(id), m_alreadySent(false) {}
