Title: [159910] trunk/Source/WebCore
- Revision
- 159910
- Author
- [email protected]
- Date
- 2013-12-01 21:41:37 -0800 (Sun, 01 Dec 2013)
Log Message
CSSFunctionValue constructors should return PassRef.
<https://webkit.org/b/125054>
Make CSSFunctionValue::create() helpers return PassRef instead of
PassRefPtr since they will never return null.
Reviewed by Anders Carlsson.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (159909 => 159910)
--- trunk/Source/WebCore/ChangeLog 2013-12-02 03:36:42 UTC (rev 159909)
+++ trunk/Source/WebCore/ChangeLog 2013-12-02 05:41:37 UTC (rev 159910)
@@ -1,3 +1,13 @@
+2013-12-01 Andreas Kling <[email protected]>
+
+ CSSFunctionValue constructors should return PassRef.
+ <https://webkit.org/b/125054>
+
+ Make CSSFunctionValue::create() helpers return PassRef instead of
+ PassRefPtr since they will never return null.
+
+ Reviewed by Anders Carlsson.
+
2013-12-01 Commit Queue <[email protected]>
Unreviewed, rolling out r159764.
Modified: trunk/Source/WebCore/css/CSSFunctionValue.h (159909 => 159910)
--- trunk/Source/WebCore/css/CSSFunctionValue.h 2013-12-02 03:36:42 UTC (rev 159909)
+++ trunk/Source/WebCore/css/CSSFunctionValue.h 2013-12-02 05:41:37 UTC (rev 159910)
@@ -35,14 +35,14 @@
class CSSFunctionValue : public CSSValue {
public:
- static PassRefPtr<CSSFunctionValue> create(CSSParserFunction* function)
+ static PassRef<CSSFunctionValue> create(CSSParserFunction* function)
{
- return adoptRef(new CSSFunctionValue(function));
+ return adoptRef(*new CSSFunctionValue(function));
}
- static PassRefPtr<CSSFunctionValue> create(String name, PassRefPtr<CSSValueList> args)
+ static PassRef<CSSFunctionValue> create(String name, PassRefPtr<CSSValueList> args)
{
- return adoptRef(new CSSFunctionValue(name, args));
+ return adoptRef(*new CSSFunctionValue(name, args));
}
String customCSSText() const;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
