Title: [159911] trunk/Source/WebCore
- Revision
- 159911
- Author
- [email protected]
- Date
- 2013-12-01 21:43:03 -0800 (Sun, 01 Dec 2013)
Log Message
Remove unreachable labels for -webkit-margin-*-collapse properties.
<https://webkit.org/b/125057>
The following properties are implemented in DeprecatedStyleBuilder
and should not have case labels in the applyProperty() switch:
-webkit-margin-before-collapse
-webkit-margin-top-collapse
-webkit-margin-after-collapse
-webkit-margin-bottom-collapse
This seems counter-intuitive, but they are actually *not* like other
directional properties. In this case, before/after are only aliases
for top/bottom, and do not depend on writing-mode or text-direction.
See also r68561, where the aliases were originally added.
Reviewed by Anders Carlsson.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (159910 => 159911)
--- trunk/Source/WebCore/ChangeLog 2013-12-02 05:41:37 UTC (rev 159910)
+++ trunk/Source/WebCore/ChangeLog 2013-12-02 05:43:03 UTC (rev 159911)
@@ -1,5 +1,25 @@
2013-12-01 Andreas Kling <[email protected]>
+ Remove unreachable labels for -webkit-margin-*-collapse properties.
+ <https://webkit.org/b/125057>
+
+ The following properties are implemented in DeprecatedStyleBuilder
+ and should not have case labels in the applyProperty() switch:
+
+ -webkit-margin-before-collapse
+ -webkit-margin-top-collapse
+ -webkit-margin-after-collapse
+ -webkit-margin-bottom-collapse
+
+ This seems counter-intuitive, but they are actually *not* like other
+ directional properties. In this case, before/after are only aliases
+ for top/bottom, and do not depend on writing-mode or text-direction.
+ See also r68561, where the aliases were originally added.
+
+ Reviewed by Anders Carlsson.
+
+2013-12-01 Andreas Kling <[email protected]>
+
CSSFunctionValue constructors should return PassRef.
<https://webkit.org/b/125054>
Modified: trunk/Source/WebCore/css/StyleResolver.cpp (159910 => 159911)
--- trunk/Source/WebCore/css/StyleResolver.cpp 2013-12-02 05:41:37 UTC (rev 159910)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2013-12-02 05:43:03 UTC (rev 159911)
@@ -2574,10 +2574,6 @@
case CSSPropertyWebkitMarginStart:
case CSSPropertyWebkitMarginBefore:
case CSSPropertyWebkitMarginAfter:
- case CSSPropertyWebkitMarginBeforeCollapse:
- case CSSPropertyWebkitMarginTopCollapse:
- case CSSPropertyWebkitMarginAfterCollapse:
- case CSSPropertyWebkitMarginBottomCollapse:
case CSSPropertyWebkitPaddingEnd:
case CSSPropertyWebkitPaddingStart:
case CSSPropertyWebkitPaddingBefore:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
