Title: [160790] trunk
- Revision
- 160790
- Author
- [email protected]
- Date
- 2013-12-18 12:50:26 -0800 (Wed, 18 Dec 2013)
Log Message
Fix page visibility api test, initialization in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=125933
Reviewed by Anders Carlsson.
The API test for page visibility is broken, fix this. This revealed a recent regression in WebKit2
(introduced in https://bugs.webkit.org/show_bug.cgi?id=123379), caused by a typo removing a '!'.
Source/WebKit2:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setVisibilityState):
- Fix regression, accidentally removed a '!'.
Tools:
* TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
(TestWebKitAPI::TEST_F):
- Running a test on WebKit1 twice is not the same as running it on WebKit2!
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (160789 => 160790)
--- trunk/Source/WebKit2/ChangeLog 2013-12-18 20:40:26 UTC (rev 160789)
+++ trunk/Source/WebKit2/ChangeLog 2013-12-18 20:50:26 UTC (rev 160790)
@@ -1,3 +1,17 @@
+2013-12-18 Gavin Barraclough <[email protected]>
+
+ Fix page visibility api test, initialization in WebKit2
+ https://bugs.webkit.org/show_bug.cgi?id=125933
+
+ Reviewed by Anders Carlsson.
+
+ The API test for page visibility is broken, fix this. This revealed a recent regression in WebKit2
+ (introduced in https://bugs.webkit.org/show_bug.cgi?id=123379), caused by a typo removing a '!'.
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::setVisibilityState):
+ - Fix regression, accidentally removed a '!'.
+
2013-12-18 Anders Carlsson <[email protected]>
Fix 32-bit build.
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (160789 => 160790)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2013-12-18 20:40:26 UTC (rev 160789)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2013-12-18 20:50:26 UTC (rev 160790)
@@ -320,7 +320,7 @@
platformInitialize();
#if ENABLE(PAGE_VISIBILITY_API)
- if (isViewVisible())
+ if (!isViewVisible())
m_visibilityState = PageVisibilityStateHidden;
#endif
#ifndef NDEBUG
Modified: trunk/Tools/ChangeLog (160789 => 160790)
--- trunk/Tools/ChangeLog 2013-12-18 20:40:26 UTC (rev 160789)
+++ trunk/Tools/ChangeLog 2013-12-18 20:50:26 UTC (rev 160790)
@@ -1,3 +1,17 @@
+2013-12-18 Gavin Barraclough <[email protected]>
+
+ Fix page visibility api test, initialization in WebKit2
+ https://bugs.webkit.org/show_bug.cgi?id=125933
+
+ Reviewed by Anders Carlsson.
+
+ The API test for page visibility is broken, fix this. This revealed a recent regression in WebKit2
+ (introduced in https://bugs.webkit.org/show_bug.cgi?id=123379), caused by a typo removing a '!'.
+
+ * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
+ (TestWebKitAPI::TEST_F):
+ - Running a test on WebKit1 twice is not the same as running it on WebKit2!
+
2013-12-18 Gergo Balogh <[email protected]>
Should not have identifiers with underscores in them, especially not leading underscores.
Modified: trunk/Tools/TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm (160789 => 160790)
--- trunk/Tools/TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm 2013-12-18 20:40:26 UTC (rev 160789)
+++ trunk/Tools/TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm 2013-12-18 20:50:26 UTC (rev 160790)
@@ -155,7 +155,7 @@
TEST_F(PageVisibilityStateWithWindowChanges, WebKit2)
{
- runWebKit1Test();
+ runWebKit2Test();
}
} // namespace TestWebKitAPI
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
