Title: [160791] trunk/Source/WebCore
- Revision
- 160791
- Author
- [email protected]
- Date
- 2013-12-18 12:58:53 -0800 (Wed, 18 Dec 2013)
Log Message
Starting a momentum scroll while rubber banding can cause scrolling to jump back
when the rubberband snaps
https://bugs.webkit.org/show_bug.cgi?id=119507
-and corresponding-
<rdar://problem/14655893>
Reviewed by Simon Fraser.
This line of code was added with the very first implementation of rubber-banding.
As far as I can tell, it was always a belt-and-suspenders line of code that is a
no-op in all normal rubber-banding. In this J-shaped scrolling case, this line of
code is what causes the bug to occur because this line of code assumes that your
rubber-band is always trying to take you back to the origin.
* platform/mac/ScrollElasticityController.mm:
(WebCore::ScrollElasticityController::snapRubberBandTimerFired):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (160790 => 160791)
--- trunk/Source/WebCore/ChangeLog 2013-12-18 20:50:26 UTC (rev 160790)
+++ trunk/Source/WebCore/ChangeLog 2013-12-18 20:58:53 UTC (rev 160791)
@@ -1,3 +1,21 @@
+2013-12-18 Beth Dakin <[email protected]>
+
+ Starting a momentum scroll while rubber banding can cause scrolling to jump back
+ when the rubberband snaps
+ https://bugs.webkit.org/show_bug.cgi?id=119507
+ -and corresponding-
+ <rdar://problem/14655893>
+
+ Reviewed by Simon Fraser.
+
+ This line of code was added with the very first implementation of rubber-banding.
+ As far as I can tell, it was always a belt-and-suspenders line of code that is a
+ no-op in all normal rubber-banding. In this J-shaped scrolling case, this line of
+ code is what causes the bug to occur because this line of code assumes that your
+ rubber-band is always trying to take you back to the origin.
+ * platform/mac/ScrollElasticityController.mm:
+ (WebCore::ScrollElasticityController::snapRubberBandTimerFired):
+
2013-12-18 Chris Fleizach <[email protected]>
AX: make aria-hidden=false work with subtrees
Modified: trunk/Source/WebCore/platform/mac/ScrollElasticityController.mm (160790 => 160791)
--- trunk/Source/WebCore/platform/mac/ScrollElasticityController.mm 2013-12-18 20:50:26 UTC (rev 160790)
+++ trunk/Source/WebCore/platform/mac/ScrollElasticityController.mm 2013-12-18 20:58:53 UTC (rev 160791)
@@ -342,8 +342,6 @@
m_stretchScrollForce.setWidth(reboundDeltaForElasticDelta(newStretch.width()));
m_stretchScrollForce.setHeight(reboundDeltaForElasticDelta(newStretch.height()));
} else {
- m_client->immediateScrollBy(m_origOrigin - m_client->absoluteScrollPosition());
-
stopSnapRubberbandTimer();
m_stretchScrollForce = FloatSize();
m_startTime = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
