Title: [164038] trunk/Source/WebCore
- Revision
- 164038
- Author
- [email protected]
- Date
- 2014-02-13 10:39:13 -0800 (Thu, 13 Feb 2014)
Log Message
InsertIntoTextNodeCommand should get Settings from the Frame.
<https://webkit.org/b/128678>
EditCommands have a frame() accessor that returns a reference,
so there's no need to go through Document.
Reviewed by Anders Carlsson.
* editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (164037 => 164038)
--- trunk/Source/WebCore/ChangeLog 2014-02-13 18:36:11 UTC (rev 164037)
+++ trunk/Source/WebCore/ChangeLog 2014-02-13 18:39:13 UTC (rev 164038)
@@ -1,3 +1,16 @@
+2014-02-13 Andreas Kling <[email protected]>
+
+ InsertIntoTextNodeCommand should get Settings from the Frame.
+ <https://webkit.org/b/128678>
+
+ EditCommands have a frame() accessor that returns a reference,
+ so there's no need to go through Document.
+
+ Reviewed by Anders Carlsson.
+
+ * editing/InsertIntoTextNodeCommand.cpp:
+ (WebCore::InsertIntoTextNodeCommand::doApply):
+
2014-02-13 László Langó <[email protected]>
Document should be constructable
Modified: trunk/Source/WebCore/editing/InsertIntoTextNodeCommand.cpp (164037 => 164038)
--- trunk/Source/WebCore/editing/InsertIntoTextNodeCommand.cpp 2014-02-13 18:36:11 UTC (rev 164037)
+++ trunk/Source/WebCore/editing/InsertIntoTextNodeCommand.cpp 2014-02-13 18:39:13 UTC (rev 164038)
@@ -29,6 +29,7 @@
#include "AXObjectCache.h"
#include "Document.h"
#include "ExceptionCodePlaceholder.h"
+#include "Frame.h"
#include "RenderText.h"
#include "Settings.h"
#include "Text.h"
@@ -51,8 +52,7 @@
void InsertIntoTextNodeCommand::doApply()
{
- // FIXME: EditCommand should always have a Frame, so going through Document for Settings shouldn't be necessary.
- bool passwordEchoEnabled = document().settings() && document().settings()->passwordEchoEnabled();
+ bool passwordEchoEnabled = frame().settings().passwordEchoEnabled();
if (passwordEchoEnabled)
document().updateLayoutIgnorePendingStylesheets();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
