Title: [164039] trunk/Source/_javascript_Core
- Revision
- 164039
- Author
- [email protected]
- Date
- 2014-02-13 10:45:09 -0800 (Thu, 13 Feb 2014)
Log Message
CStack Branch: VM::currentReturnThunkPC appears to be unused and should be removed
https://bugs.webkit.org/show_bug.cgi?id=127205
Reviewed by Geoffrey Garen.
Removed ununsed references to VM::currentReturnThunkPC.
* jit/ThunkGenerators.cpp:
(JSC::arityFixup):
* runtime/VM.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (164038 => 164039)
--- trunk/Source/_javascript_Core/ChangeLog 2014-02-13 18:39:13 UTC (rev 164038)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-02-13 18:45:09 UTC (rev 164039)
@@ -1,3 +1,16 @@
+2014-02-13 Michael Saboff <[email protected]>
+
+ CStack Branch: VM::currentReturnThunkPC appears to be unused and should be removed
+ https://bugs.webkit.org/show_bug.cgi?id=127205
+
+ Reviewed by Geoffrey Garen.
+
+ Removed ununsed references to VM::currentReturnThunkPC.
+
+ * jit/ThunkGenerators.cpp:
+ (JSC::arityFixup):
+ * runtime/VM.h:
+
2014-02-13 Tamas Gergely <[email protected]>
Code cleanup: remove gcc<4.7 guards.
Modified: trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp (164038 => 164039)
--- trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp 2014-02-13 18:39:13 UTC (rev 164038)
+++ trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp 2014-02-13 18:45:09 UTC (rev 164039)
@@ -428,7 +428,7 @@
JSInterfaceJIT jit(vm);
// We enter with fixup count, in aligned stack units, in regT0 and the return thunk in
- // regT5. We use VM::currentReturnThunkPC instead of regT5 on X86-32.
+ // regT5.
#if USE(JSVALUE64)
# if CPU(X86_64)
jit.pop(JSInterfaceJIT::regT4);
@@ -514,13 +514,7 @@
jit.storePtr(GPRInfo::regT1, MacroAssembler::BaseIndex(JSInterfaceJIT::regT3, JSInterfaceJIT::regT0, JSInterfaceJIT::TimesEight));
// Install the new return PC.
- // FIXME: I don't think currentReturnThunkPC is used and should be deleted.
-# if 0
- jit.loadPtr(&vm->currentReturnThunkPC, GPRInfo::regT2);
- jit.storePtr(GPRInfo::regT2, JSInterfaceJIT::Address(JSInterfaceJIT::callFrameRegister, CallFrame::returnPCOffset()));
-# else
jit.storePtr(GPRInfo::regT5, JSInterfaceJIT::Address(JSInterfaceJIT::callFrameRegister, CallFrame::returnPCOffset()));
-# endif
# if CPU(X86)
jit.push(JSInterfaceJIT::regT4);
Modified: trunk/Source/_javascript_Core/runtime/VM.h (164038 => 164039)
--- trunk/Source/_javascript_Core/runtime/VM.h 2014-02-13 18:39:13 UTC (rev 164038)
+++ trunk/Source/_javascript_Core/runtime/VM.h 2014-02-13 18:45:09 UTC (rev 164039)
@@ -342,9 +342,6 @@
NativeExecutable* getHostFunction(NativeFunction, Intrinsic);
std::unique_ptr<ArityCheckFailReturnThunks> arityCheckFailReturnThunks;
-#if CPU(X86)
- void* currentReturnThunkPC;
-#endif // CPU(X86)
#endif // ENABLE(JIT)
std::unique_ptr<CommonSlowPaths::ArityCheckData> arityCheckData;
#if ENABLE(FTL_JIT)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
