Title: [164880] trunk/Source/_javascript_Core
Revision
164880
Author
[email protected]
Date
2014-02-28 13:03:41 -0800 (Fri, 28 Feb 2014)

Log Message

REGRESSION(r164835): It broke 10 JSC stress test on 32 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=129488

Reviewed by Mark Lam.

Whoops, modify the right register.

* jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (164879 => 164880)


--- trunk/Source/_javascript_Core/ChangeLog	2014-02-28 21:00:12 UTC (rev 164879)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-28 21:03:41 UTC (rev 164880)
@@ -1,3 +1,15 @@
+2014-02-28  Oliver Hunt  <[email protected]>
+
+        REGRESSION(r164835): It broke 10 JSC stress test on 32 bit platforms
+        https://bugs.webkit.org/show_bug.cgi?id=129488
+
+        Reviewed by Mark Lam.
+
+        Whoops, modify the right register.
+
+        * jit/JITCall32_64.cpp:
+        (JSC::JIT::compileLoadVarargs):
+
 2014-02-28  Filip Pizlo  <[email protected]>
 
         FTL should be able to call sin/cos directly on platforms where the intrinsic is busted

Modified: trunk/Source/_javascript_Core/jit/JITCall32_64.cpp (164879 => 164880)


--- trunk/Source/_javascript_Core/jit/JITCall32_64.cpp	2014-02-28 21:00:12 UTC (rev 164879)
+++ trunk/Source/_javascript_Core/jit/JITCall32_64.cpp	2014-02-28 21:03:41 UTC (rev 164880)
@@ -144,11 +144,11 @@
 
         load32(payloadFor(JSStack::ArgumentCount), regT2);
         if (firstVarArgOffset) {
-            Jump sufficientArguments = branch32(GreaterThan, regT0, TrustedImm32(firstVarArgOffset + 1));
-            move(TrustedImm32(1), regT0);
+            Jump sufficientArguments = branch32(GreaterThan, regT2, TrustedImm32(firstVarArgOffset + 1));
+            move(TrustedImm32(1), regT2);
             Jump endVarArgs = jump();
             sufficientArguments.link(this);
-            sub32(TrustedImm32(firstVarArgOffset), regT0);
+            sub32(TrustedImm32(firstVarArgOffset), regT2);
             endVarArgs.link(this);
         }
         slowCase.append(branch32(Above, regT2, TrustedImm32(Arguments::MaxArguments + 1)));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to