Title: [164881] trunk/Source/WebCore
Revision
164881
Author
[email protected]
Date
2014-02-28 13:12:54 -0800 (Fri, 28 Feb 2014)

Log Message

[Mac, iOS] Incorrect ordering of construction arguments for out-of-band text elements
https://bugs.webkit.org/show_bug.cgi?id=129501
<rdar://problem/16198587>

Reviewed by Eric Carlson.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): Correct order of arguments
to PlatformTextTrack.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (164880 => 164881)


--- trunk/Source/WebCore/ChangeLog	2014-02-28 21:03:41 UTC (rev 164880)
+++ trunk/Source/WebCore/ChangeLog	2014-02-28 21:12:54 UTC (rev 164881)
@@ -1,3 +1,15 @@
+2014-02-28  Brent Fulgham  <[email protected]>
+
+        [Mac, iOS] Incorrect ordering of construction arguments for out-of-band text elements
+        https://bugs.webkit.org/show_bug.cgi?id=129501
+        <rdar://problem/16198587>
+
+        Reviewed by Eric Carlson.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::parseAttribute): Correct order of arguments
+        to PlatformTextTrack.
+
 2014-02-28  Bem Jones-Bey  <[email protected]>
 
         Properly clear m_logicallyLastRun to remove use-after-free possibility

Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (164880 => 164881)


--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2014-02-28 21:03:41 UTC (rev 164880)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2014-02-28 21:12:54 UTC (rev 164881)
@@ -5565,7 +5565,7 @@
         else
             continue;
 
-        outOfBandTrackSources.append(PlatformTextTrack::createOutOfBand(url.string(), trackElement.label(), trackElement.srclang(), platformKind, ++uniqueId, trackElement.isDefault()));
+        outOfBandTrackSources.append(PlatformTextTrack::createOutOfBand(trackElement.label(), trackElement.srclang(), url.string(), platformKind, ++uniqueId, trackElement.isDefault()));
     }
     
     return outOfBandTrackSources;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to