Title: [167045] trunk/Source/WebCore
Revision
167045
Author
commit-qu...@webkit.org
Date
2014-04-09 15:35:12 -0700 (Wed, 09 Apr 2014)

Log Message

Fullscreen does two view controller changes at once
https://bugs.webkit.org/show_bug.cgi?id=131432

Patch by Jeremy Jones <jere...@apple.com> on 2014-04-09
Reviewed by Eric Carlson.

* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::enterFullscreen):
delay -presentViewController on the main run loop to allow
previous view controller change to complete.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (167044 => 167045)


--- trunk/Source/WebCore/ChangeLog	2014-04-09 22:33:23 UTC (rev 167044)
+++ trunk/Source/WebCore/ChangeLog	2014-04-09 22:35:12 UTC (rev 167045)
@@ -1,5 +1,17 @@
 2014-04-09  Jeremy Jones  <jere...@apple.com>
 
+        Fullscreen does two view controller changes at once
+        https://bugs.webkit.org/show_bug.cgi?id=131432
+
+        Reviewed by Eric Carlson.
+
+        * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+        (WebVideoFullscreenInterfaceAVKit::enterFullscreen):
+        delay -presentViewController on the main run loop to allow
+        previous view controller change to complete.
+
+2014-04-09  Jeremy Jones  <jere...@apple.com>
+
         Enable fullscreen captions selection
         https://bugs.webkit.org/show_bug.cgi?id=131069
 

Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (167044 => 167045)


--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2014-04-09 22:33:23 UTC (rev 167044)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2014-04-09 22:35:12 UTC (rev 167045)
@@ -538,11 +538,14 @@
         
         __block RefPtr<WebVideoFullscreenInterfaceAVKit> protect2(this);
 
-        [m_viewController presentViewController:m_playerViewController.get() animated:YES completion:^{
-            if (m_fullscreenChangeObserver)
-                m_fullscreenChangeObserver->didEnterFullscreen();
-            protect2.clear();
-        }];
+        dispatch_async(dispatch_get_main_queue(), ^{
+            [m_viewController presentViewController:m_playerViewController.get() animated:YES completion:^{
+                if (m_fullscreenChangeObserver)
+                    m_fullscreenChangeObserver->didEnterFullscreen();
+                protect2.clear();
+            }];
+        });
+        
         protect.clear();
     });
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to