Title: [167046] trunk
Revision
167046
Author
mmaxfi...@apple.com
Date
2014-04-09 15:54:26 -0700 (Wed, 09 Apr 2014)

Log Message

Remove "System Font" from whitelisted DRT fonts and char width calculations
https://bugs.webkit.org/show_bug.cgi?id=131411

Reviewed by Tim Horton.

Covered by existing tests.

Source/WebCore:

* platform/graphics/Font.cpp:
(WebCore::Font::hasValidAverageCharWidth):

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (167045 => 167046)


--- trunk/Source/WebCore/ChangeLog	2014-04-09 22:35:12 UTC (rev 167045)
+++ trunk/Source/WebCore/ChangeLog	2014-04-09 22:54:26 UTC (rev 167046)
@@ -1,3 +1,15 @@
+2014-04-09  Myles C. Maxfield  <mmaxfi...@apple.com>
+
+        Remove "System Font" from whitelisted DRT fonts and char width calculations
+        https://bugs.webkit.org/show_bug.cgi?id=131411
+
+        Reviewed by Tim Horton.
+
+        Covered by existing tests.
+
+        * platform/graphics/Font.cpp:
+        (WebCore::Font::hasValidAverageCharWidth):
+
 2014-04-09  Jeremy Jones  <jere...@apple.com>
 
         Fullscreen does two view controller changes at once

Modified: trunk/Source/WebCore/platform/graphics/Font.cpp (167045 => 167046)


--- trunk/Source/WebCore/platform/graphics/Font.cpp	2014-04-09 22:35:12 UTC (rev 167045)
+++ trunk/Source/WebCore/platform/graphics/Font.cpp	2014-04-09 22:54:26 UTC (rev 167046)
@@ -484,7 +484,7 @@
     // Internal fonts on OS X also have an invalid entry in the table for avgCharWidth.
     // They are hidden by having a name that begins with a period, so simply search
     // for that here rather than try to keep the list up to date.
-    if (family.startsWith('.') || family == "System Font")
+    if (family.startsWith('.'))
         return false;
 
     static HashSet<AtomicString>* fontFamiliesWithInvalidCharWidthMap = 0;

Modified: trunk/Tools/ChangeLog (167045 => 167046)


--- trunk/Tools/ChangeLog	2014-04-09 22:35:12 UTC (rev 167045)
+++ trunk/Tools/ChangeLog	2014-04-09 22:54:26 UTC (rev 167046)
@@ -1,5 +1,17 @@
 2014-04-09  Myles C. Maxfield  <mmaxfi...@apple.com>
 
+        Remove "System Font" from whitelisted DRT fonts and char width calculations
+        https://bugs.webkit.org/show_bug.cgi?id=131411
+
+        Reviewed by Tim Horton.
+
+        Covered by existing tests.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (allowedFontFamilySet):
+
+2014-04-09  Myles C. Maxfield  <mmaxfi...@apple.com>
+
         systemHiddenFontFamilySet in DRT is unnecessary
         https://bugs.webkit.org/show_bug.cgi?id=131414
 

Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (167045 => 167046)


--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2014-04-09 22:35:12 UTC (rev 167045)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2014-04-09 22:54:26 UTC (rev 167046)
@@ -397,7 +397,6 @@
         @"STKaiti",
         @"STSong",
         @"Symbol",
-        @"System Font",
         @"Tahoma",
         @"Thonburi",
         @"Times New Roman",
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to