Title: [169239] trunk/Source/WebKit2
- Revision
- 169239
- Author
- [email protected]
- Date
- 2014-05-22 19:24:07 -0700 (Thu, 22 May 2014)
Log Message
Do not force a layout when changing the FixedLayoutSize in WebPage
https://bugs.webkit.org/show_bug.cgi?id=133167
Patch by Benjamin Poulain <[email protected]> on 2014-05-22
Reviewed by Andreas Kling.
WebPage::setFixedLayoutSize was forcing a layout immediately after changing the layout size on FrameView.
This is forcing plenty of extra layouts since the fixed layout size is one of many properties updated on the FrameView.
FrameView marks that layout is needed. It is not clear why a layout was performed immediately.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setFixedLayoutSize):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (169238 => 169239)
--- trunk/Source/WebKit2/ChangeLog 2014-05-23 01:47:30 UTC (rev 169238)
+++ trunk/Source/WebKit2/ChangeLog 2014-05-23 02:24:07 UTC (rev 169239)
@@ -1,3 +1,18 @@
+2014-05-22 Benjamin Poulain <[email protected]>
+
+ Do not force a layout when changing the FixedLayoutSize in WebPage
+ https://bugs.webkit.org/show_bug.cgi?id=133167
+
+ Reviewed by Andreas Kling.
+
+ WebPage::setFixedLayoutSize was forcing a layout immediately after changing the layout size on FrameView.
+ This is forcing plenty of extra layouts since the fixed layout size is one of many properties updated on the FrameView.
+
+ FrameView marks that layout is needed. It is not clear why a layout was performed immediately.
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::setFixedLayoutSize):
+
2014-05-22 Andreas Kling <[email protected]>
[iOS WebKit2] Web process should try to shrink its memory footprint when going into background.
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (169238 => 169239)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-05-23 01:47:30 UTC (rev 169238)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-05-23 02:24:07 UTC (rev 169239)
@@ -1436,9 +1436,6 @@
return;
view->setFixedLayoutSize(size);
- // Do not force it until the first layout, this would then become our first layout prematurely.
- if (view->didFirstLayout())
- view->forceLayout();
}
void WebPage::listenForLayoutMilestones(uint32_t milestones)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
