Title: [169240] trunk/Source/WebKit2
- Revision
- 169240
- Author
- [email protected]
- Date
- 2014-05-22 20:16:33 -0700 (Thu, 22 May 2014)
Log Message
[iOS][WK2] Reset the special action-target of WKSyntheticClickTapGestureRecognizer on destruction
https://bugs.webkit.org/show_bug.cgi?id=133165
<rdar://problem/16283914>
Patch by Benjamin Poulain <[email protected]> on 2014-05-22
Reviewed by Andy Estes.
It is unclear why, but the WKSyntheticClickTapGestureRecognizer sometimes survives its own view
and is reset after WKContentView was destructed.
This patch cleans up the target-action on destruction to avoid accessing a destructed object.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (169239 => 169240)
--- trunk/Source/WebKit2/ChangeLog 2014-05-23 02:24:07 UTC (rev 169239)
+++ trunk/Source/WebKit2/ChangeLog 2014-05-23 03:16:33 UTC (rev 169240)
@@ -1,5 +1,20 @@
2014-05-22 Benjamin Poulain <[email protected]>
+ [iOS][WK2] Reset the special action-target of WKSyntheticClickTapGestureRecognizer on destruction
+ https://bugs.webkit.org/show_bug.cgi?id=133165
+ <rdar://problem/16283914>
+
+ Reviewed by Andy Estes.
+
+ It is unclear why, but the WKSyntheticClickTapGestureRecognizer sometimes survives its own view
+ and is reset after WKContentView was destructed.
+ This patch cleans up the target-action on destruction to avoid accessing a destructed object.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView cleanupInteraction]):
+
+2014-05-22 Benjamin Poulain <[email protected]>
+
Do not force a layout when changing the FixedLayoutSize in WebPage
https://bugs.webkit.org/show_bug.cgi?id=133167
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (169239 => 169240)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2014-05-23 02:24:07 UTC (rev 169239)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2014-05-23 03:16:33 UTC (rev 169240)
@@ -240,6 +240,9 @@
[_highlightRootView removeFromSuperview];
[_touchEventGestureRecognizer setDelegate:nil];
[_singleTapGestureRecognizer setDelegate:nil];
+ [_singleTapGestureRecognizer setGestureRecognizedTarget:nil action:nil];
+ [_singleTapGestureRecognizer setResetTarget:nil action:nil];
+
[_doubleTapGestureRecognizer setDelegate:nil];
[_highlightLongPressGestureRecognizer setDelegate:nil];
[_longPressGestureRecognizer setDelegate:nil];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
