Title: [170363] trunk/Source/WebCore
Revision
170363
Author
jer.no...@apple.com
Date
2014-06-24 09:14:34 -0700 (Tue, 24 Jun 2014)

Log Message

[MSE] Add null-check in sourceBufferPrivateAppendComplete().
https://bugs.webkit.org/show_bug.cgi?id=133230

Reviewed by Eric Carlson.

* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Bail early if the
    SourceBuffer has been removed from the MediaSource.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (170362 => 170363)


--- trunk/Source/WebCore/ChangeLog	2014-06-24 16:05:11 UTC (rev 170362)
+++ trunk/Source/WebCore/ChangeLog	2014-06-24 16:14:34 UTC (rev 170363)
@@ -1,3 +1,14 @@
+2014-06-24  Jer Noble  <jer.no...@apple.com>
+
+        [MSE] Add null-check in sourceBufferPrivateAppendComplete().
+        https://bugs.webkit.org/show_bug.cgi?id=133230
+
+        Reviewed by Eric Carlson.
+
+        * Modules/mediasource/SourceBuffer.cpp:
+        (WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Bail early if the 
+            SourceBuffer has been removed from the MediaSource.
+
 2014-06-24  Commit Queue  <commit-qu...@webkit.org>
 
         Unreviewed, rolling out r170337.

Modified: trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp (170362 => 170363)


--- trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp	2014-06-24 16:05:11 UTC (rev 170362)
+++ trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp	2014-06-24 16:14:34 UTC (rev 170363)
@@ -498,6 +498,9 @@
 
 void SourceBuffer::sourceBufferPrivateAppendComplete(SourceBufferPrivate*, AppendResult result)
 {
+    if (isRemoved())
+        return;
+
     // Section 3.5.5 Buffer Append Algorithm, ctd.
     // https://dvcs.w3.org/hg/html-media/raw-file/default/media-source/media-source.html#sourcebuffer-buffer-append
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to