[webkit-changes] [170364] trunk/Source

Tue, 24 Jun 2014 09:19:32 -0700

Title: [170364] trunk/Source
Revision
170364
Author
[email protected]
Date
2014-06-24 09:18:52 -0700 (Tue, 24 Jun 2014)

Log Message

Fix unused parameter warnings if inspector is disabled
https://bugs.webkit.org/show_bug.cgi?id=134244

Patch by Eva Balazsfalvi <[email protected]> on 2014-06-24
Reviewed by Zalan Bujtas.

Source/WebCore:
No new tests, no behavior change.

* inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::startProfiling):
(WebCore::InspectorInstrumentation::stopProfiling):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didFinishXHRLoading):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):

Source/WebKit2:
* WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:
(WKBundleInspectorShow):
(WKBundleInspectorClose):
(WKBundleInspectorEvaluateScriptForTest):
(WKBundleInspectorSetPageProfilingEnabled):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (170363 => 170364)


--- trunk/Source/WebCore/ChangeLog	2014-06-24 16:14:34 UTC (rev 170363)
+++ trunk/Source/WebCore/ChangeLog	2014-06-24 16:18:52 UTC (rev 170364)
@@ -1,3 +1,20 @@
+2014-06-24  Eva Balazsfalvi  <[email protected]>
+
+        Fix unused parameter warnings if inspector is disabled
+        https://bugs.webkit.org/show_bug.cgi?id=134244
+
+        Reviewed by Zalan Bujtas.
+
+        No new tests, no behavior change.
+
+        * inspector/InspectorConsoleInstrumentation.h:
+        (WebCore::InspectorInstrumentation::startProfiling):
+        (WebCore::InspectorInstrumentation::stopProfiling):
+        * inspector/InspectorInstrumentation.h:
+        (WebCore::InspectorInstrumentation::didFinishXHRLoading):
+        * loader/cache/CachedResourceLoader.cpp:
+        (WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):
+
 2014-06-24  Jer Noble  <[email protected]>
 
         [MSE] Add null-check in sourceBufferPrivateAppendComplete().

Modified: trunk/Source/WebCore/inspector/InspectorConsoleInstrumentation.h (170363 => 170364)


--- trunk/Source/WebCore/inspector/InspectorConsoleInstrumentation.h	2014-06-24 16:14:34 UTC (rev 170363)
+++ trunk/Source/WebCore/inspector/InspectorConsoleInstrumentation.h	2014-06-24 16:18:52 UTC (rev 170364)
@@ -180,6 +180,7 @@
         startProfilingImpl(instrumentingAgents, exec, title);
 #else
     UNUSED_PARAM(page);
+    UNUSED_PARAM(exec);
     UNUSED_PARAM(title);
 #endif
 }
@@ -191,6 +192,7 @@
         return stopProfilingImpl(instrumentingAgents, exec, title);
 #else
     UNUSED_PARAM(page);
+    UNUSED_PARAM(exec);
     UNUSED_PARAM(title);
 #endif
     return nullptr;

Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.h (170363 => 170364)


--- trunk/Source/WebCore/inspector/InspectorInstrumentation.h	2014-06-24 16:14:34 UTC (rev 170363)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.h	2014-06-24 16:18:52 UTC (rev 170364)
@@ -1439,6 +1439,7 @@
     UNUSED_PARAM(url);
     UNUSED_PARAM(sendURL);
     UNUSED_PARAM(sendLineNumber);
+    UNUSED_PARAM(sendColumnNumber);
 #endif
 }

Modified: trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp (170363 => 170364)


--- trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp	2014-06-24 16:14:34 UTC (rev 170363)
+++ trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp	2014-06-24 16:18:52 UTC (rev 170364)
@@ -401,6 +401,8 @@
 #if ENABLE(INSPECTOR)
     if (request.resourceRequest().hiddenFromInspector())
         newRequest.setHiddenFromInspector(true);
+#else
+    UNUSED_PARAM(request);
 #endif
     frame()->loader().loadedResourceFromMemoryCache(resource, newRequest);

Modified: trunk/Source/WebKit2/ChangeLog (170363 => 170364)


--- trunk/Source/WebKit2/ChangeLog	2014-06-24 16:14:34 UTC (rev 170363)
+++ trunk/Source/WebKit2/ChangeLog	2014-06-24 16:18:52 UTC (rev 170364)
@@ -1,3 +1,16 @@
+2014-06-24  Eva Balazsfalvi  <[email protected]>
+
+        Fix unused parameter warnings if inspector is disabled
+        https://bugs.webkit.org/show_bug.cgi?id=134244
+
+        Reviewed by Zalan Bujtas.
+
+        * WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:
+        (WKBundleInspectorShow):
+        (WKBundleInspectorClose):
+        (WKBundleInspectorEvaluateScriptForTest):
+        (WKBundleInspectorSetPageProfilingEnabled):
+
 2014-06-24  Anders Carlsson  <[email protected]>
 
         WKWebView doesn't respect -[UIScrollView contentInset]

Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp (170363 => 170364)


--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp	2014-06-24 16:14:34 UTC (rev 170363)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp	2014-06-24 16:18:52 UTC (rev 170364)
@@ -46,6 +46,8 @@
 {
 #if ENABLE(INSPECTOR)
     toImpl(inspectorRef)->show();
+#else
+    UNUSED_PARAM(inspectorRef);
 #endif
 }
 
@@ -53,6 +55,8 @@
 {
 #if ENABLE(INSPECTOR)
     toImpl(inspectorRef)->close();
+#else
+    UNUSED_PARAM(inspectorRef);
 #endif
 }
 
@@ -60,6 +64,9 @@
 {
 #if ENABLE(INSPECTOR)
     toImpl(inspectorRef)->evaluateScriptForTest(toWTFString(script));
+#else
+    UNUSED_PARAM(script);
+    UNUSED_PARAM(inspectorRef);
 #endif
 }
 
@@ -70,5 +77,8 @@
         toImpl(inspectorRef)->startPageProfiling();
     else
         toImpl(inspectorRef)->stopPageProfiling();
+#else
+    UNUSED_PARAM(enabled);
+    UNUSED_PARAM(inspectorRef);
 #endif
 }

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to