Title: [171193] trunk/Tools
Revision
171193
Author
[email protected]
Date
2014-07-17 12:31:48 -0700 (Thu, 17 Jul 2014)

Log Message

Disable button animations in regression tests
https://bugs.webkit.org/show_bug.cgi?id=133647
<rdar://problem/16677530>

Reviewed by Dean Jackson.

* DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
We already did this for WebKit2, let's do it for WebKit1 too.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (171192 => 171193)


--- trunk/Tools/ChangeLog	2014-07-17 19:20:31 UTC (rev 171192)
+++ trunk/Tools/ChangeLog	2014-07-17 19:31:48 UTC (rev 171193)
@@ -1,3 +1,14 @@
+2014-07-17  Alexey Proskuryakov  <[email protected]>
+
+        Disable button animations in regression tests
+        https://bugs.webkit.org/show_bug.cgi?id=133647
+        <rdar://problem/16677530>
+
+        Reviewed by Dean Jackson.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
+        We already did this for WebKit2, let's do it for WebKit1 too.
+
 2014-07-16  Alexey Proskuryakov  <[email protected]>
 
         A test that hangs at cleanup stage confuses webkitpy hugely

Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (171192 => 171193)


--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2014-07-17 19:20:31 UTC (rev 171192)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2014-07-17 19:31:48 UTC (rev 171193)
@@ -940,6 +940,7 @@
 #endif
         @"NSOverlayScrollersEnabled": @NO,
         @"AppleShowScrollBars": @"Always",
+        @"NSButtonAnimationsEnabled": @NO, // Ideally, we should find a way to test animations, but for now, make sure that the dumped snapshot matches actual state.
         WebDatabaseDirectoryDefaultsKey: [libraryPath stringByAppendingPathComponent:@"Databases"],
         WebStorageDirectoryDefaultsKey: [libraryPath stringByAppendingPathComponent:@"LocalStorage"],
         WebKitLocalCacheDefaultsKey: [libraryPath stringByAppendingPathComponent:@"LocalCache"]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to