Title: [171194] trunk/Source/WebKit2
- Revision
- 171194
- Author
- [email protected]
- Date
- 2014-07-17 14:04:54 -0700 (Thu, 17 Jul 2014)
Log Message
Crash in ServicesOverlayController::~ServicesOverlayController.
<rdar://problem/17622172> and https://bugs.webkit.org/show_bug.cgi?id=135022
Reviewed by Tim Horton.
* WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::~ServicesOverlayController): Don’t need to uninstall the
PageOverlay as it has already been destroyed by this point in WebPage::~WebPage.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (171193 => 171194)
--- trunk/Source/WebKit2/ChangeLog 2014-07-17 19:31:48 UTC (rev 171193)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-17 21:04:54 UTC (rev 171194)
@@ -1,3 +1,14 @@
+2014-07-17 Brady Eidson <[email protected]>
+
+ Crash in ServicesOverlayController::~ServicesOverlayController.
+ <rdar://problem/17622172> and https://bugs.webkit.org/show_bug.cgi?id=135022
+
+ Reviewed by Tim Horton.
+
+ * WebProcess/WebPage/mac/ServicesOverlayController.mm:
+ (WebKit::ServicesOverlayController::~ServicesOverlayController): Don’t need to uninstall the
+ PageOverlay as it has already been destroyed by this point in WebPage::~WebPage.
+
2014-07-17 Tim Horton <[email protected]>
Sometimes purgeable (or empty!) tiles are shown on screen when resuming the app
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm (171193 => 171194)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm 2014-07-17 19:31:48 UTC (rev 171193)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm 2014-07-17 21:04:54 UTC (rev 171194)
@@ -81,10 +81,6 @@
ServicesOverlayController::~ServicesOverlayController()
{
- if (m_servicesOverlay) {
- ASSERT(m_webPage);
- m_webPage->uninstallPageOverlay(m_servicesOverlay, PageOverlay::FadeMode::DoNotFade);
- }
}
void ServicesOverlayController::pageOverlayDestroyed(PageOverlay*)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
