Title: [174783] trunk/Websites/bugs.webkit.org/code-review.js
Revision
174783
Author
[email protected]
Date
2014-10-16 09:01:35 -0700 (Thu, 16 Oct 2014)

Log Message

Fix loading of legacy comments from older Bugzillas

* code-review.js:
(fetchHistory): We must support both the old-style and new-style
formats for attachment comments since the old-style format is
quoted and stored as text in the database forever.

Modified Paths

Diff

Modified: trunk/Websites/bugs.webkit.org/code-review.js (174782 => 174783)


--- trunk/Websites/bugs.webkit.org/code-review.js	2014-10-16 16:01:34 UTC (rev 174782)
+++ trunk/Websites/bugs.webkit.org/code-review.js	2014-10-16 16:01:35 UTC (rev 174783)
@@ -559,8 +559,13 @@
           var text = $(this).find('.bz_comment_text').text();
 
           var comment_marker = 'Comment on attachment ' + attachment_id + ' .details.';
-          if (text.match(comment_marker))
+          if (text.match(comment_marker)) {
             $.merge(comments, scanForComments(author, text));
+          } else {
+              comment_marker = '(From update of attachment ' + attachment_id + ' .details.)';
+              if (text.match(comment_marker))
+                $.merge(comments, scanForComments(author, text));
+          }
 
           var style_queue_comment_marker = 'Attachment ' + attachment_id + ' .details. did not pass style-queue.'
           if (text.match(style_queue_comment_marker))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to