Title: [174785] trunk/Websites/bugs.webkit.org/template/en/default
- Revision
- 174785
- Author
- [email protected]
- Date
- 2014-10-16 09:01:37 -0700 (Thu, 16 Oct 2014)
Log Message
Fix _javascript_ alert() about missing search terms when submitting patch review
* template/en/default/attachment/reviewform.html.tmpl: Pass
hide_content=1 argument when including global/header.html.tmpl.
* template/en/default/global/header.html.tmpl: Add hide_content argument
that hides header content when including the file.
Modified Paths
Diff
Modified: trunk/Websites/bugs.webkit.org/template/en/default/attachment/reviewform.html.tmpl (174784 => 174785)
--- trunk/Websites/bugs.webkit.org/template/en/default/attachment/reviewform.html.tmpl 2014-10-16 16:01:36 UTC (rev 174784)
+++ trunk/Websites/bugs.webkit.org/template/en/default/attachment/reviewform.html.tmpl 2014-10-16 16:01:37 UTC (rev 174785)
@@ -25,7 +25,6 @@
#comment { width: 100%; height: 100%; font-family: monospace; }
#form-controls { height: 40px; }
#form-controls td { width: 25%; text-align: center; }
-#header { display: none; }
</style>
[% _javascript_ = BLOCK %]
@@ -55,6 +54,7 @@
[% END %]
[% PROCESS global/header.html.tmpl
+ hide_content = 1
_javascript_ = _javascript_
%]
Modified: trunk/Websites/bugs.webkit.org/template/en/default/global/header.html.tmpl (174784 => 174785)
--- trunk/Websites/bugs.webkit.org/template/en/default/global/header.html.tmpl 2014-10-16 16:01:36 UTC (rev 174784)
+++ trunk/Websites/bugs.webkit.org/template/en/default/global/header.html.tmpl 2014-10-16 16:01:37 UTC (rev 174785)
@@ -35,6 +35,7 @@
# style_urls: list. List of URLs to CSS style sheets.
# message: string. A message to display to the user. May contain HTML.
# rsslink: RSS link URL, May contain HTML (WEBKIT_CHANGES)
+ # hide_content: boolean. Turns off content if not being used. (WEBKIT_CHANGES)
#%]
[% IF message %]
@@ -260,6 +261,8 @@
# 'bannerhtml'
#%]
+[% IF !hide_content %][%# WEBKIT_CHANGES #%]
+
<div id="header">
[%# if WEBKIT_CHANGES #%]
@@ -306,6 +309,8 @@
[% PROCESS "global/common-links.html.tmpl" qs_suffix = "_top" %]
</div> [%# header %]
+[% END %][%# !hide_content #%][%# WEBKIT_CHANGES #%]
+
<div id="bugzilla-body">
[% IF Param('announcehtml') %]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
