Title: [175134] tags/Safari-601.1.5/Source/_javascript_Core
Revision
175134
Author
[email protected]
Date
2014-10-23 12:26:46 -0700 (Thu, 23 Oct 2014)

Log Message

Merged r175058. <rdar://problem/18739720>

Modified Paths

Diff

Modified: tags/Safari-601.1.5/Source/_javascript_Core/ChangeLog (175133 => 175134)


--- tags/Safari-601.1.5/Source/_javascript_Core/ChangeLog	2014-10-23 19:17:09 UTC (rev 175133)
+++ tags/Safari-601.1.5/Source/_javascript_Core/ChangeLog	2014-10-23 19:26:46 UTC (rev 175134)
@@ -1,3 +1,22 @@
+2014-10-23  Babak Shafiei  <[email protected]>
+
+        Merge r175058.
+
+    2014-10-22  Michael Saboff  <[email protected]>
+
+            REGRESSION(r174996): Broke C_LOOP
+            https://bugs.webkit.org/show_bug.cgi?id=137971
+
+            Reviewed by Mark Lam.
+
+            Removed incorrect move to cfr (CallFrameRegister) before we make the call to a native function.
+            After r174996, the source register for the move contained garbage causing the crash.  The move
+            to cfr before making the call to the native function is wrong and should have been removed
+            some time ago.  This brings the ARM64 / C_LOOP code path inline with the other CPU paths.
+            Tested on ARM64 as well as a C_LOOP build.
+
+            * llint/LowLevelInterpreter64.asm:
+
 2014-10-21  Mark Lam  <[email protected]>
 
         Remove erroneous canUseJIT() in the intrinsics version of JITThunks::hostFunctionStub().

Modified: tags/Safari-601.1.5/Source/_javascript_Core/llint/LowLevelInterpreter64.asm (175133 => 175134)


--- tags/Safari-601.1.5/Source/_javascript_Core/llint/LowLevelInterpreter64.asm	2014-10-23 19:17:09 UTC (rev 175133)
+++ tags/Safari-601.1.5/Source/_javascript_Core/llint/LowLevelInterpreter64.asm	2014-10-23 19:26:46 UTC (rev 175134)
@@ -1951,7 +1951,6 @@
         move cfr, t0
         loadp Callee[cfr], t1
         loadp JSFunction::m_executable[t1], t1
-        move t2, cfr # Restore cfr to avoid loading from stack
         if C_LOOP
             cloopCallNative executableOffsetToFunction[t1]
         else
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to