Title: [175135] trunk/Source/WebKit2
- Revision
- 175135
- Author
- [email protected]
- Date
- 2014-10-23 12:38:26 -0700 (Thu, 23 Oct 2014)
Log Message
[iOS] iPhone unselecting items in <select multiple> shows incorrect values selected
https://bugs.webkit.org/show_bug.cgi?id=137989
Patch by Joseph Pecoraro <[email protected]> on 2014-10-23
Reviewed by Alexey Proskuryakov.
* UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKMultipleSelectPicker pickerView:row:column:checked:]):
The second argument is "allowsMultipleSelection" and should only be set
when we are making a selection in a <select multiple>.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (175134 => 175135)
--- trunk/Source/WebKit2/ChangeLog 2014-10-23 19:26:46 UTC (rev 175134)
+++ trunk/Source/WebKit2/ChangeLog 2014-10-23 19:38:26 UTC (rev 175135)
@@ -1,3 +1,15 @@
+2014-10-23 Joseph Pecoraro <[email protected]>
+
+ [iOS] iPhone unselecting items in <select multiple> shows incorrect values selected
+ https://bugs.webkit.org/show_bug.cgi?id=137989
+
+ Reviewed by Alexey Proskuryakov.
+
+ * UIProcess/ios/forms/WKFormSelectPicker.mm:
+ (-[WKMultipleSelectPicker pickerView:row:column:checked:]):
+ The second argument is "allowsMultipleSelection" and should only be set
+ when we are making a selection in a <select multiple>.
+
2014-10-23 Tim Horton <[email protected]>
Assertion failures in ImageKit soft linking
Modified: trunk/Source/WebKit2/UIProcess/ios/forms/WKFormSelectPicker.mm (175134 => 175135)
--- trunk/Source/WebKit2/UIProcess/ios/forms/WKFormSelectPicker.mm 2014-10-23 19:26:46 UTC (rev 175134)
+++ trunk/Source/WebKit2/UIProcess/ios/forms/WKFormSelectPicker.mm 2014-10-23 19:38:26 UTC (rev 175135)
@@ -280,7 +280,7 @@
OptionItem& item = [_view assistedNodeSelectOptions][rowIndex];
if ([self allowsMultipleSelection]) {
- [_view page]->setAssistedNodeSelectedIndex([self findItemIndexAt:rowIndex], isChecked);
+ [_view page]->setAssistedNodeSelectedIndex([self findItemIndexAt:rowIndex], true);
item.isSelected = isChecked;
} else {
// Single selection.
@@ -290,7 +290,7 @@
// This private delegate often gets called for multiple rows in the picker,
// so we only activate and set as selected the checked item in single selection.
if (isChecked) {
- [_view page]->setAssistedNodeSelectedIndex([self findItemIndexAt:rowIndex], isChecked);
+ [_view page]->setAssistedNodeSelectedIndex([self findItemIndexAt:rowIndex]);
item.isSelected = YES;
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
