Title: [175158] trunk/Source/WebCore
Revision
175158
Author
[email protected]
Date
2014-10-23 20:35:27 -0700 (Thu, 23 Oct 2014)

Log Message

WebContent crash at WebCore::RenderTextControl::textFormControlElement const.
https://bugs.webkit.org/show_bug.cgi?id=138035

Reviewed by Antti Koivisto.

NULL-check element().renderer() before using it.

* html/SearchInputType.cpp:
(WebCore::SearchInputType::didSetValueByUserEdit):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (175157 => 175158)


--- trunk/Source/WebCore/ChangeLog	2014-10-24 03:00:35 UTC (rev 175157)
+++ trunk/Source/WebCore/ChangeLog	2014-10-24 03:35:27 UTC (rev 175158)
@@ -1,3 +1,15 @@
+2014-10-23  Zalan Bujtas  <[email protected]>
+
+        WebContent crash at WebCore::RenderTextControl::textFormControlElement const.
+        https://bugs.webkit.org/show_bug.cgi?id=138035
+
+        Reviewed by Antti Koivisto.
+
+        NULL-check element().renderer() before using it.
+
+        * html/SearchInputType.cpp:
+        (WebCore::SearchInputType::didSetValueByUserEdit):
+
 2014-10-23  Gyuyoung Kim  <[email protected]>
 
         Remove HarfBuzzRun::create() factory function

Modified: trunk/Source/WebCore/html/SearchInputType.cpp (175157 => 175158)


--- trunk/Source/WebCore/html/SearchInputType.cpp	2014-10-24 03:00:35 UTC (rev 175157)
+++ trunk/Source/WebCore/html/SearchInputType.cpp	2014-10-24 03:35:27 UTC (rev 175158)
@@ -185,7 +185,7 @@
 
 void SearchInputType::didSetValueByUserEdit(ValueChangeState state)
 {
-    if (m_cancelButton)
+    if (m_cancelButton && element().renderer())
         downcast<RenderSearchField>(*element().renderer()).updateCancelButtonVisibility();
 
     // If the incremental attribute is set, then dispatch the search event
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to