Title: [175166] trunk/Tools
- Revision
- 175166
- Author
- [email protected]
- Date
- 2014-10-24 10:03:53 -0700 (Fri, 24 Oct 2014)
Log Message
build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
https://bugs.webkit.org/show_bug.cgi?id=138046
Reviewed by Alexey Proskuryakov.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
401. Otherwise, we’ll retry normally in 45 seconds.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js (175165 => 175166)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2014-10-24 09:12:41 UTC (rev 175165)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2014-10-24 17:03:53 UTC (rev 175166)
@@ -136,6 +136,8 @@
callback(data);
}.bind(this),
function(data) {
+ if (data.errorType !== JSON.LoadError || data.errorHTTPCode !== 401)
+ return;
if (this.buildbot.isAuthenticated) {
// FIXME (128006): Safari/WebKit should coalesce authentication requests with the same origin and authentication realm.
// In absence of the fix, Safari presents additional authentication dialogs regardless of whether an earlier authentication
@@ -145,10 +147,9 @@
this._load(url, callback);
return;
}
- if (data.errorType === JSON.LoadError && data.errorHTTPCode === 401) {
- this.buildbot.isAuthenticated = false;
- this.dispatchEventToListeners(BuildbotQueue.Event.UnauthorizedAccess, { });
- }
+
+ this.buildbot.isAuthenticated = false;
+ this.dispatchEventToListeners(BuildbotQueue.Event.UnauthorizedAccess, { });
}.bind(this),
{withCredentials: this.buildbot.needsAuthentication}
);
Modified: trunk/Tools/ChangeLog (175165 => 175166)
--- trunk/Tools/ChangeLog 2014-10-24 09:12:41 UTC (rev 175165)
+++ trunk/Tools/ChangeLog 2014-10-24 17:03:53 UTC (rev 175166)
@@ -1,3 +1,14 @@
+2014-10-24 Dan Bernstein <[email protected]>
+
+ build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
+ https://bugs.webkit.org/show_bug.cgi?id=138046
+
+ Reviewed by Alexey Proskuryakov.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
+ (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
+ 401. Otherwise, we’ll retry normally in 45 seconds.
+
2014-10-24 Marcos Chavarría Teijeiro <[email protected]>
[GTK] Implement is_selected method on WebKitHitTestResult
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
