Title: [176236] trunk/Source/WebKit/mac
Revision
176236
Author
[email protected]
Date
2014-11-17 15:26:44 -0800 (Mon, 17 Nov 2014)

Log Message

Remove calls to deprecated NSMenu methods
https://bugs.webkit.org/show_bug.cgi?id=138808.

Reviewed by Anders Carlsson.

-[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.

* WebCoreSupport/PopupMenuMac.mm:
(PopupMenuMac::populate):

Modified Paths

Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (176235 => 176236)


--- trunk/Source/WebKit/mac/ChangeLog	2014-11-17 23:17:51 UTC (rev 176235)
+++ trunk/Source/WebKit/mac/ChangeLog	2014-11-17 23:26:44 UTC (rev 176236)
@@ -1,3 +1,15 @@
+2014-11-17  Brian Weinstein  <[email protected]>
+
+        Remove calls to deprecated NSMenu methods
+        https://bugs.webkit.org/show_bug.cgi?id=138808.
+
+        Reviewed by Anders Carlsson.
+
+        -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
+
+        * WebCoreSupport/PopupMenuMac.mm:
+        (PopupMenuMac::populate):
+
 2014-11-17  Daniel Bates  <[email protected]>
 
         Unreviewed, rolling out r176232.

Modified: trunk/Source/WebKit/mac/WebCoreSupport/PopupMenuMac.mm (176235 => 176236)


--- trunk/Source/WebKit/mac/WebCoreSupport/PopupMenuMac.mm	2014-11-17 23:17:51 UTC (rev 176235)
+++ trunk/Source/WebKit/mac/WebCoreSupport/PopupMenuMac.mm	2014-11-17 23:26:44 UTC (rev 176236)
@@ -61,9 +61,6 @@
         [m_popup setUsesItemFromMenu:NO];
         [m_popup setAutoenablesItems:NO];
     }
-
-    BOOL messagesEnabled = [[m_popup menu] menuChangedMessagesEnabled];
-    [[m_popup menu] setMenuChangedMessagesEnabled:NO];
     
     // For pullDown menus the first item is hidden.
     if (!m_client->shouldPopOver())
@@ -126,8 +123,6 @@
         }
 #pragma clang diagnostic pop
     }
-
-    [[m_popup menu] setMenuChangedMessagesEnabled:messagesEnabled];
 }
 
 void PopupMenuMac::show(const IntRect& r, FrameView* v, int index)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to