Title: [176237] trunk/Source/WebKit2
- Revision
- 176237
- Author
- [email protected]
- Date
- 2014-11-17 16:47:40 -0800 (Mon, 17 Nov 2014)
Log Message
Preview is sometimes dismissed too early
https://bugs.webkit.org/show_bug.cgi?id=138811
-and corresponding-
rdar://problem/18900839
Reviewed by Tim Horton.
Don’t make the popover transient until didCloseMenu: time.
* UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController didCloseMenu:withEvent:]):
(-[WKActionMenuController _createPreviewPopoverForURL:originRect:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (176236 => 176237)
--- trunk/Source/WebKit2/ChangeLog 2014-11-17 23:26:44 UTC (rev 176236)
+++ trunk/Source/WebKit2/ChangeLog 2014-11-18 00:47:40 UTC (rev 176237)
@@ -1,3 +1,17 @@
+2014-11-17 Beth Dakin <[email protected]>
+
+ Preview is sometimes dismissed too early
+ https://bugs.webkit.org/show_bug.cgi?id=138811
+ -and corresponding-
+ rdar://problem/18900839
+
+ Reviewed by Tim Horton.
+
+ Don’t make the popover transient until didCloseMenu: time.
+ * UIProcess/mac/WKActionMenuController.mm:
+ (-[WKActionMenuController didCloseMenu:withEvent:]):
+ (-[WKActionMenuController _createPreviewPopoverForURL:originRect:]):
+
2014-11-17 Daniel Bates <[email protected]>
Unreviewed, rolling out r176232.
Modified: trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm (176236 => 176237)
--- trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm 2014-11-17 23:26:44 UTC (rev 176236)
+++ trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm 2014-11-18 00:47:40 UTC (rev 176237)
@@ -231,6 +231,7 @@
[getDDActionsManagerClass() didUseActions];
}
+ [_previewPopover setBehavior:NSPopoverBehaviorTransient];
if (!_shouldKeepPreviewPopoverOpen)
[self _clearPreviewPopover];
@@ -338,7 +339,7 @@
_previewViewController->_delegate = self;
_previewPopover = adoptNS([[NSPopover alloc] init]);
- [_previewPopover setBehavior:NSPopoverBehaviorTransient];
+ [_previewPopover setBehavior:NSPopoverBehaviorApplicationDefined];
[_previewPopover setContentSize:popoverSize];
[_previewPopover setContentViewController:_previewViewController.get()];
[_previewPopover setDelegate:self];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
