Diff
Modified: trunk/Source/WebKit/ChangeLog (176550 => 176551)
--- trunk/Source/WebKit/ChangeLog 2014-11-27 17:58:41 UTC (rev 176550)
+++ trunk/Source/WebKit/ChangeLog 2014-11-27 18:00:10 UTC (rev 176551)
@@ -1,3 +1,12 @@
+2014-11-27 Anders Carlsson <[email protected]>
+
+ Add a stubbed out WebVisitedLinkStore to WebViewGroup
+ https://bugs.webkit.org/show_bug.cgi?id=139066
+
+ Reviewed by Antti Koivisto.
+
+ * WebKit.xcodeproj/project.pbxproj:
+
2014-11-21 Anders Carlsson <[email protected]>
Add a new symbol.
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (176550 => 176551)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2014-11-27 17:58:41 UTC (rev 176550)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2014-11-27 18:00:10 UTC (rev 176551)
@@ -58,6 +58,8 @@
1AAF5FC00EDE3A92008D883D /* WebHostedNetscapePluginView.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1AAF5FBE0EDE3A92008D883D /* WebHostedNetscapePluginView.mm */; };
1AB1DAC118BC0232004B6A9F /* WebViewGroup.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1AB1DABF18BC0232004B6A9F /* WebViewGroup.mm */; };
1AB1DAC218BC0232004B6A9F /* WebViewGroup.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AB1DAC018BC0232004B6A9F /* WebViewGroup.h */; };
+ 1AC7176E1A26568A002E3115 /* WebVisitedLinkStore.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1AC7176C1A26568A002E3115 /* WebVisitedLinkStore.mm */; };
+ 1AC7176F1A26568A002E3115 /* WebVisitedLinkStore.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AC7176D1A26568A002E3115 /* WebVisitedLinkStore.h */; };
1AEA66D40DC6B1FF003D12BF /* WebNetscapePluginEventHandler.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AEA66D20DC6B1FF003D12BF /* WebNetscapePluginEventHandler.h */; };
1AEA66D50DC6B1FF003D12BF /* WebNetscapePluginEventHandler.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1AEA66D30DC6B1FF003D12BF /* WebNetscapePluginEventHandler.mm */; };
1AEA66D80DC6B209003D12BF /* WebNetscapePluginEventHandlerCarbon.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AEA66D60DC6B209003D12BF /* WebNetscapePluginEventHandlerCarbon.h */; };
@@ -498,6 +500,8 @@
1AAF5FBE0EDE3A92008D883D /* WebHostedNetscapePluginView.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebHostedNetscapePluginView.mm; sourceTree = "<group>"; };
1AB1DABF18BC0232004B6A9F /* WebViewGroup.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebViewGroup.mm; sourceTree = "<group>"; };
1AB1DAC018BC0232004B6A9F /* WebViewGroup.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebViewGroup.h; sourceTree = "<group>"; };
+ 1AC7176C1A26568A002E3115 /* WebVisitedLinkStore.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebVisitedLinkStore.mm; sourceTree = "<group>"; };
+ 1AC7176D1A26568A002E3115 /* WebVisitedLinkStore.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebVisitedLinkStore.h; sourceTree = "<group>"; };
1AEA66D20DC6B1FF003D12BF /* WebNetscapePluginEventHandler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebNetscapePluginEventHandler.h; sourceTree = "<group>"; };
1AEA66D30DC6B1FF003D12BF /* WebNetscapePluginEventHandler.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebNetscapePluginEventHandler.mm; sourceTree = "<group>"; };
1AEA66D60DC6B209003D12BF /* WebNetscapePluginEventHandlerCarbon.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebNetscapePluginEventHandlerCarbon.h; sourceTree = "<group>"; };
@@ -1570,6 +1574,8 @@
93EB178C09F88D460091F8FF /* WebSystemInterface.mm */,
1AB1DAC018BC0232004B6A9F /* WebViewGroup.h */,
1AB1DABF18BC0232004B6A9F /* WebViewGroup.mm */,
+ 1AC7176D1A26568A002E3115 /* WebVisitedLinkStore.h */,
+ 1AC7176C1A26568A002E3115 /* WebVisitedLinkStore.mm */,
);
name = WebCoreSupport;
path = mac/WebCoreSupport;
@@ -1864,6 +1870,7 @@
A10C1D801820303D0036883A /* WebMailDelegate.h in Headers */,
939810B10824BF01008DF038 /* WebPluginContainerCheck.h in Headers */,
939810B00824BF01008DF038 /* WebPluginContainerPrivate.h in Headers */,
+ 1AC7176F1A26568A002E3115 /* WebVisitedLinkStore.h in Headers */,
939810370824BF01008DF038 /* WebPluginController.h in Headers */,
7C1FB3C21846E8E1001A03D8 /* WebAllowDenyPolicyListener.h in Headers */,
939810380824BF01008DF038 /* WebPluginDatabase.h in Headers */,
@@ -2148,6 +2155,7 @@
5241ADF60B1BC48A004012BD /* WebCache.mm in Sources */,
14D825300AF955090004F057 /* WebChromeClient.mm in Sources */,
A10C1D711820300E0036883A /* WebInspectorClientIOS.mm in Sources */,
+ 1AC7176E1A26568A002E3115 /* WebVisitedLinkStore.mm in Sources */,
939810EB0824BF01008DF038 /* WebClipView.mm in Sources */,
065AD5A40B0C32C7005A2B1D /* WebContextMenuClient.mm in Sources */,
939810BF0824BF01008DF038 /* WebCoreStatistics.mm in Sources */,
Modified: trunk/Source/WebKit/mac/ChangeLog (176550 => 176551)
--- trunk/Source/WebKit/mac/ChangeLog 2014-11-27 17:58:41 UTC (rev 176550)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-11-27 18:00:10 UTC (rev 176551)
@@ -1,3 +1,22 @@
+2014-11-27 Anders Carlsson <[email protected]>
+
+ Add a stubbed out WebVisitedLinkStore to WebViewGroup
+ https://bugs.webkit.org/show_bug.cgi?id=139066
+
+ Reviewed by Antti Koivisto.
+
+ * WebCoreSupport/WebViewGroup.h:
+ (WebViewGroup::visitedLinkStore):
+ * WebCoreSupport/WebViewGroup.mm:
+ (WebViewGroup::WebViewGroup):
+ * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
+ * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
+ (WebVisitedLinkStore::create):
+ (WebVisitedLinkStore::WebVisitedLinkStore):
+ (WebVisitedLinkStore::~WebVisitedLinkStore):
+ (WebVisitedLinkStore::isLinkVisited):
+ (WebVisitedLinkStore::addVisitedLink):
+
2014-11-25 Anders Carlsson <[email protected]>
Remove user content handling from PageGroup
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebViewGroup.h (176550 => 176551)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebViewGroup.h 2014-11-27 17:58:41 UTC (rev 176550)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebViewGroup.h 2014-11-27 18:00:10 UTC (rev 176551)
@@ -25,6 +25,8 @@
#import <WebCore/UserContentController.h>
+class WebVisitedLinkStore;
+
@class WebView;
class WebViewGroup : public RefCounted<WebViewGroup> {
@@ -38,6 +40,7 @@
void removeWebView(WebView *);
WebCore::UserContentController& userContentController() { return m_userContentController.get(); }
+ WebVisitedLinkStore& visitedLinkStore() { return m_visitedLinkStore.get(); }
private:
WebViewGroup(const String& name);
@@ -46,4 +49,5 @@
HashSet<WebView *> m_webViews;
Ref<WebCore::UserContentController> m_userContentController;
+ Ref<WebVisitedLinkStore> m_visitedLinkStore;
};
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebViewGroup.mm (176550 => 176551)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebViewGroup.mm 2014-11-27 17:58:41 UTC (rev 176550)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebViewGroup.mm 2014-11-27 18:00:10 UTC (rev 176551)
@@ -26,6 +26,7 @@
#import "WebViewGroup.h"
#import "WebView.h"
+#import "WebVisitedLinkStore.h"
#import <wtf/NeverDestroyed.h>
#import <wtf/text/StringHash.h>
@@ -61,6 +62,7 @@
WebViewGroup::WebViewGroup(const String& name)
: m_name(name)
, m_userContentController(*UserContentController::create())
+ , m_visitedLinkStore(WebVisitedLinkStore::create())
{
}
Copied: trunk/Source/WebKit/mac/WebCoreSupport/WebVisitedLinkStore.h (from rev 176550, trunk/Source/WebKit/mac/WebCoreSupport/WebViewGroup.h) (0 => 176551)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebVisitedLinkStore.h (rev 0)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebVisitedLinkStore.h 2014-11-27 18:00:10 UTC (rev 176551)
@@ -0,0 +1,44 @@
+/*
+ * Copyright (C) 2014 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef WebVisitedLinkStore_h
+#define WebVisitedLinkStore_h
+
+#import <WebCore/VisitedLinkStore.h>
+#import <wtf/PassRef.h>
+
+class WebVisitedLinkStore final : public WebCore::VisitedLinkStore {
+public:
+ static PassRef<WebVisitedLinkStore> create();
+ virtual ~WebVisitedLinkStore();
+
+private:
+ WebVisitedLinkStore();
+
+ virtual bool isLinkVisited(WebCore::Page&, WebCore::LinkHash, const WebCore::URL& baseURL, const AtomicString& attributeURL) override;
+ virtual void addVisitedLink(WebCore::Page&, WebCore::LinkHash) override;
+};
+
+#endif // WebVisitedLinkStore_h
Copied: trunk/Source/WebKit/mac/WebCoreSupport/WebVisitedLinkStore.mm (from rev 176550, trunk/Source/WebKit/mac/WebCoreSupport/WebViewGroup.h) (0 => 176551)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebVisitedLinkStore.mm (rev 0)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebVisitedLinkStore.mm 2014-11-27 18:00:10 UTC (rev 176551)
@@ -0,0 +1,50 @@
+/*
+ * Copyright (C) 2014 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#import "WebVisitedLinkStore.h"
+
+PassRef<WebVisitedLinkStore> WebVisitedLinkStore::create()
+{
+ return adoptRef(*new WebVisitedLinkStore);
+}
+
+WebVisitedLinkStore::WebVisitedLinkStore()
+{
+}
+
+WebVisitedLinkStore::~WebVisitedLinkStore()
+{
+}
+
+bool WebVisitedLinkStore::isLinkVisited(WebCore::Page&, WebCore::LinkHash, const WebCore::URL& baseURL, const AtomicString& attributeURL)
+{
+ // FIXME: Implement.
+ return false;
+}
+
+void WebVisitedLinkStore::addVisitedLink(WebCore::Page&, WebCore::LinkHash)
+{
+ // FIXME: Implement.
+}
