Title: [176554] trunk/Source/WebCore
- Revision
- 176554
- Author
- [email protected]
- Date
- 2014-11-27 17:40:01 -0800 (Thu, 27 Nov 2014)
Log Message
CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::HTMLPlugInImageElement::updateSnapshot + 108
https://bugs.webkit.org/show_bug.cgi?id=139057
Reviewed by Anders Carlsson.
No test, don't know how to repro.
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::updateSnapshot): Null check the renderer.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (176553 => 176554)
--- trunk/Source/WebCore/ChangeLog 2014-11-28 00:51:32 UTC (rev 176553)
+++ trunk/Source/WebCore/ChangeLog 2014-11-28 01:40:01 UTC (rev 176554)
@@ -1,3 +1,15 @@
+2014-11-27 Antti Koivisto <[email protected]>
+
+ CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::HTMLPlugInImageElement::updateSnapshot + 108
+ https://bugs.webkit.org/show_bug.cgi?id=139057
+
+ Reviewed by Anders Carlsson.
+
+ No test, don't know how to repro.
+
+ * html/HTMLPlugInImageElement.cpp:
+ (WebCore::HTMLPlugInImageElement::updateSnapshot): Null check the renderer.
+
2014-11-27 Joanmarie Diggs <[email protected]>
AX: [ATK] Meter and Option elements do not expose their id attribute
Modified: trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp (176553 => 176554)
--- trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp 2014-11-28 00:51:32 UTC (rev 176553)
+++ trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp 2014-11-28 01:40:01 UTC (rev 176554)
@@ -332,13 +332,17 @@
m_snapshotImage = image;
- if (is<RenderSnapshottedPlugIn>(*renderer())) {
- downcast<RenderSnapshottedPlugIn>(*renderer()).updateSnapshot(image);
+ if (!renderer())
return;
+ auto& renderer = *this->renderer();
+
+ if (is<RenderSnapshottedPlugIn>(renderer)) {
+ downcast<RenderSnapshottedPlugIn>(renderer).updateSnapshot(image);
+ return;
}
- if (is<RenderEmbeddedObject>(*renderer()))
- renderer()->repaint();
+ if (is<RenderEmbeddedObject>(renderer))
+ renderer.repaint();
}
static DOMWrapperWorld& plugInImageElementIsolatedWorld()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
