Title: [177303] trunk/Source
- Revision
- 177303
- Author
- [email protected]
- Date
- 2014-12-15 12:26:23 -0800 (Mon, 15 Dec 2014)
Log Message
Implement Data Detectors immediate actions for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=139617
<rdar://problem/19198539>
Reviewed by Beth Dakin.
* platform/spi/mac/DataDetectorsSPI.h:
Add some new SPI.
* UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _menuItemForDataDetectedText]):
Note that this action context is only for immediate actions.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (177302 => 177303)
--- trunk/Source/WebCore/ChangeLog 2014-12-15 20:24:45 UTC (rev 177302)
+++ trunk/Source/WebCore/ChangeLog 2014-12-15 20:26:23 UTC (rev 177303)
@@ -1,3 +1,14 @@
+2014-12-15 Timothy Horton <[email protected]>
+
+ Implement Data Detectors immediate actions for WebKit2
+ https://bugs.webkit.org/show_bug.cgi?id=139617
+ <rdar://problem/19198539>
+
+ Reviewed by Beth Dakin.
+
+ * platform/spi/mac/DataDetectorsSPI.h:
+ Add some new SPI.
+
2014-12-12 Simon Fraser <[email protected]>
REGRESSION (r168217): Images are cropped out during animation at jetblue.com
Modified: trunk/Source/WebCore/platform/spi/mac/DataDetectorsSPI.h (177302 => 177303)
--- trunk/Source/WebCore/platform/spi/mac/DataDetectorsSPI.h 2014-12-15 20:24:45 UTC (rev 177302)
+++ trunk/Source/WebCore/platform/spi/mac/DataDetectorsSPI.h 2014-12-15 20:26:23 UTC (rev 177303)
@@ -71,6 +71,7 @@
@property (retain) NSArray *allResults;
@property (retain) __attribute__((NSObject)) DDResultRef mainResult;
@property (assign) BOOL altMode;
+@property (assign) BOOL immediate;
- (DDActionContext *)contextForView:(NSView *)view altMode:(BOOL)altMode interactionStartedHandler:(void (^)(void))interactionStartedHandler interactionChangedHandler:(void (^)(void))interactionChangedHandler interactionStoppedHandler:(void (^)(void))interactionStoppedHandler;
Modified: trunk/Source/WebKit2/ChangeLog (177302 => 177303)
--- trunk/Source/WebKit2/ChangeLog 2014-12-15 20:24:45 UTC (rev 177302)
+++ trunk/Source/WebKit2/ChangeLog 2014-12-15 20:26:23 UTC (rev 177303)
@@ -1,3 +1,15 @@
+2014-12-15 Timothy Horton <[email protected]>
+
+ Implement Data Detectors immediate actions for WebKit2
+ https://bugs.webkit.org/show_bug.cgi?id=139617
+ <rdar://problem/19198539>
+
+ Reviewed by Beth Dakin.
+
+ * UIProcess/mac/WKImmediateActionController.mm:
+ (-[WKImmediateActionController _menuItemForDataDetectedText]):
+ Note that this action context is only for immediate actions.
+
2014-12-15 Myles C. Maxfield <[email protected]>
Addressing post-review comments in r177035
Modified: trunk/Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm (177302 => 177303)
--- trunk/Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm 2014-12-15 20:24:45 UTC (rev 177302)
+++ trunk/Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm 2014-12-15 20:26:23 UTC (rev 177303)
@@ -454,6 +454,7 @@
return nil;
actionContext.altMode = YES;
+ actionContext.immediate = YES;
if ([[getDDActionsManagerClass() sharedManager] respondsToSelector:@selector(hasActionsForResult:actionContext:)]) {
if (![[getDDActionsManagerClass() sharedManager] hasActionsForResult:actionContext.mainResult actionContext:actionContext])
return nil;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
