Title: [177304] trunk/Source/WebKit/mac
- Revision
- 177304
- Author
- [email protected]
- Date
- 2014-12-15 12:27:24 -0800 (Mon, 15 Dec 2014)
Log Message
Implement Data Detectors immediate actions for Legacy WebKit
https://bugs.webkit.org/show_bug.cgi?id=139619
<rdar://problem/19198539>
Reviewed by Beth Dakin.
* WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _menuItemForDataDetectedText]):
Note that this action context is only for immediate actions.
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (177303 => 177304)
--- trunk/Source/WebKit/mac/ChangeLog 2014-12-15 20:26:23 UTC (rev 177303)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-12-15 20:27:24 UTC (rev 177304)
@@ -1,3 +1,15 @@
+2014-12-15 Timothy Horton <[email protected]>
+
+ Implement Data Detectors immediate actions for Legacy WebKit
+ https://bugs.webkit.org/show_bug.cgi?id=139619
+ <rdar://problem/19198539>
+
+ Reviewed by Beth Dakin.
+
+ * WebView/WebImmediateActionController.mm:
+ (-[WebImmediateActionController _menuItemForDataDetectedText]):
+ Note that this action context is only for immediate actions.
+
2014-12-15 Myles C. Maxfield <[email protected]>
Addressing post-review comments in r177035
Modified: trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm (177303 => 177304)
--- trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm 2014-12-15 20:26:23 UTC (rev 177303)
+++ trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm 2014-12-15 20:27:24 UTC (rev 177304)
@@ -250,6 +250,7 @@
return nil;
[actionContext setAltMode:YES];
+ [actionContext setImmediate:YES];
if ([[getDDActionsManagerClass() sharedManager] respondsToSelector:@selector(hasActionsForResult:actionContext:)]) {
if (![[getDDActionsManagerClass() sharedManager] hasActionsForResult:[actionContext mainResult] actionContext:actionContext.get()])
return nil;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes