Title: [179660] trunk/Websites/perf.webkit.org
- Revision
- 179660
- Author
- [email protected]
- Date
- 2015-02-04 19:33:08 -0800 (Wed, 04 Feb 2015)
Log Message
New perf dashboard erroneously clears zoom when poping history items
https://bugs.webkit.org/show_bug.cgi?id=141278
Reviewed by Chris Dumez.
The bug was caused by _sharedZoomChanged updating overviewSelection without updating mainPlotDomain.
Updating overviewSelection resulted in _overviewSelectionChanged, which observes changes to overviewSelection,
to schedule a call to propagateZoom, which in turn overrode "sharedZoom" we just parsed from the query string.
* public/v2/app.js:
(App.PaneController._overviewSelectionChanged): Don't schedule propagateZoom if the selected domain is already
shown in the main plot.
(App.PaneController._sharedZoomChanged): Set both overviewSelection and mainPlotDomain to avoid overriding
"sharedZoom" via propagateZoom inside _overviewSelectionChanged.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (179659 => 179660)
--- trunk/Websites/perf.webkit.org/ChangeLog 2015-02-05 03:11:29 UTC (rev 179659)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-02-05 03:33:08 UTC (rev 179660)
@@ -1,5 +1,23 @@
2015-02-04 Ryosuke Niwa <[email protected]>
+ New perf dashboard erroneously clears zoom when poping history items
+ https://bugs.webkit.org/show_bug.cgi?id=141278
+
+ Reviewed by Chris Dumez.
+
+ The bug was caused by _sharedZoomChanged updating overviewSelection without updating mainPlotDomain.
+
+ Updating overviewSelection resulted in _overviewSelectionChanged, which observes changes to overviewSelection,
+ to schedule a call to propagateZoom, which in turn overrode "sharedZoom" we just parsed from the query string.
+
+ * public/v2/app.js:
+ (App.PaneController._overviewSelectionChanged): Don't schedule propagateZoom if the selected domain is already
+ shown in the main plot.
+ (App.PaneController._sharedZoomChanged): Set both overviewSelection and mainPlotDomain to avoid overriding
+ "sharedZoom" via propagateZoom inside _overviewSelectionChanged.
+
+2015-02-04 Ryosuke Niwa <[email protected]>
+
New perf dashboard shows null as the aggregator name if no aggregation is done
https://bugs.webkit.org/show_bug.cgi?id=141256
Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (179659 => 179660)
--- trunk/Websites/perf.webkit.org/public/v2/app.js 2015-02-05 03:11:29 UTC (rev 179659)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2015-02-05 03:33:08 UTC (rev 179660)
@@ -680,6 +680,8 @@
_overviewSelectionChanged: function ()
{
var overviewSelection = this.get('overviewSelection');
+ if (App.domainsAreEqual(overviewSelection, this.get('mainPlotDomain')))
+ return;
this.set('mainPlotDomain', overviewSelection || this.get('overviewDomain'));
Ember.run.debounce(this, 'propagateZoom', 100);
}.observes('overviewSelection'),
@@ -701,6 +703,7 @@
var newSelection = this.get('parentController').get('sharedZoom');
if (App.domainsAreEqual(newSelection, this.get('mainPlotDomain')))
return;
+ this.set('mainPlotDomain', newSelection);
this.set('overviewSelection', newSelection);
}.observes('parentController.sharedZoom').on('init'),
_updateDetails: function ()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
