Title: [179661] trunk/Websites/perf.webkit.org
- Revision
- 179661
- Author
- [email protected]
- Date
- 2015-02-04 19:36:21 -0800 (Wed, 04 Feb 2015)
Log Message
New perf dashboard doesn't preserve the number of days when clicking on a dashboard chart
https://bugs.webkit.org/show_bug.cgi?id=141280
Reviewed by Chris Dumez.
Fixed the bug by passing in "since" as a query parameter to the charts page.
Also fixed the styling issue that manifests when a JSON fetching fails on "Dashboard" page.
* public/v2/app.css: Fixed CSS rules for error messages shown in the place of charts.
* public/v2/app.js:
(App.IndexController): Changed the default number of days from one month to one week.
(App.IndexController._sharedDomainChanged): Set "since" property on the controller.
* public/v2/index.html: Pass in "since" property on the controller as a query parameter.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (179660 => 179661)
--- trunk/Websites/perf.webkit.org/ChangeLog 2015-02-05 03:33:08 UTC (rev 179660)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-02-05 03:36:21 UTC (rev 179661)
@@ -1,5 +1,22 @@
2015-02-04 Ryosuke Niwa <[email protected]>
+ New perf dashboard doesn't preserve the number of days when clicking on a dashboard chart
+ https://bugs.webkit.org/show_bug.cgi?id=141280
+
+ Reviewed by Chris Dumez.
+
+ Fixed the bug by passing in "since" as a query parameter to the charts page.
+
+ Also fixed the styling issue that manifests when a JSON fetching fails on "Dashboard" page.
+
+ * public/v2/app.css: Fixed CSS rules for error messages shown in the place of charts.
+ * public/v2/app.js:
+ (App.IndexController): Changed the default number of days from one month to one week.
+ (App.IndexController._sharedDomainChanged): Set "since" property on the controller.
+ * public/v2/index.html: Pass in "since" property on the controller as a query parameter.
+
+2015-02-04 Ryosuke Niwa <[email protected]>
+
New perf dashboard erroneously clears zoom when poping history items
https://bugs.webkit.org/show_bug.cgi?id=141278
Modified: trunk/Websites/perf.webkit.org/public/v2/app.css (179660 => 179661)
--- trunk/Websites/perf.webkit.org/public/v2/app.css 2015-02-05 03:33:08 UTC (rev 179660)
+++ trunk/Websites/perf.webkit.org/public/v2/app.css 2015-02-05 03:36:21 UTC (rev 179661)
@@ -403,15 +403,21 @@
}
table.dashboard tbody td .chart,
-table.dashboard tbody td .failure,
table.dashboard tbody td .progress {
display: inline-block;
width: 100%;
height: 12rem;
line-height: 12rem;
- vertical-align: center;
+ vertical-align: middle;
}
+table.dashboard tbody td .failure {
+ display: table-cell;
+ width: 100%;
+ height: 12rem;
+ vertical-align: middle;
+}
+
#analysis-tasks,
.analysis-group > table {
border: solid 0px #999;
Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (179660 => 179661)
--- trunk/Websites/perf.webkit.org/public/v2/app.js 2015-02-05 03:33:08 UTC (rev 179660)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2015-02-05 03:36:21 UTC (rev 179661)
@@ -59,7 +59,7 @@
_previousGrid: {},
headerColumns: [],
rows: [],
- numberOfDays: 30,
+ numberOfDays: 7,
editMode: false,
gridChanged: function ()
@@ -119,6 +119,7 @@
numberOfDays = parseInt(numberOfDays);
var present = Date.now();
var past = present - numberOfDays * 24 * 3600 * 1000;
+ this.set('since', past);
this.set('sharedDomain', [past, present]);
}.observes('numberOfDays').on('init'),
Modified: trunk/Websites/perf.webkit.org/public/v2/index.html (179660 => 179661)
--- trunk/Websites/perf.webkit.org/public/v2/index.html 2015-02-05 03:33:08 UTC (rev 179660)
+++ trunk/Websites/perf.webkit.org/public/v2/index.html 2015-02-05 03:36:21 UTC (rev 179661)
@@ -78,7 +78,7 @@
{{/if}}
{{else}}
{{#if chartData}}
- {{#link-to 'charts' (query-params paneList=paneList)}}
+ {{#link-to 'charts' (query-params paneList=paneList since=controller.since)}}
{{interactive-chart
chartData=chartData
domain=controller.sharedDomain
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
