Title: [179817] trunk/Source/_javascript_Core
- Revision
- 179817
- Author
- [email protected]
- Date
- 2015-02-08 18:42:22 -0800 (Sun, 08 Feb 2015)
Log Message
Remove a few duplicate propagation steps from the DFG's PredictionPropagation phase
https://bugs.webkit.org/show_bug.cgi?id=141363
Reviewed by Darin Adler.
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
Some blocks were duplicated, they probably evolved separately
to the same state.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (179816 => 179817)
--- trunk/Source/_javascript_Core/ChangeLog 2015-02-09 02:40:09 UTC (rev 179816)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-02-09 02:42:22 UTC (rev 179817)
@@ -1,5 +1,17 @@
2015-02-08 Benjamin Poulain <[email protected]>
+ Remove a few duplicate propagation steps from the DFG's PredictionPropagation phase
+ https://bugs.webkit.org/show_bug.cgi?id=141363
+
+ Reviewed by Darin Adler.
+
+ * dfg/DFGPredictionPropagationPhase.cpp:
+ (JSC::DFG::PredictionPropagationPhase::propagate):
+ Some blocks were duplicated, they probably evolved separately
+ to the same state.
+
+2015-02-08 Benjamin Poulain <[email protected]>
+
Remove useless declarations and a stale comment from DFGByteCodeParser.h
https://bugs.webkit.org/show_bug.cgi?id=141361
Modified: trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp (179816 => 179817)
--- trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp 2015-02-09 02:40:09 UTC (rev 179816)
+++ trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp 2015-02-09 02:42:22 UTC (rev 179817)
@@ -249,22 +249,8 @@
}
break;
}
-
- case ArithAdd: {
- SpeculatedType left = node->child1()->prediction();
- SpeculatedType right = node->child2()->prediction();
-
- if (left && right) {
- if (m_graph.addSpeculationMode(node, m_pass) != DontSpeculateInt32)
- changed |= mergePrediction(SpecInt32);
- else if (m_graph.addShouldSpeculateMachineInt(node))
- changed |= mergePrediction(SpecInt52);
- else
- changed |= mergePrediction(speculatedDoubleTypeForPredictions(left, right));
- }
- break;
- }
-
+
+ case ArithAdd:
case ArithSub: {
SpeculatedType left = node->child1()->prediction();
SpeculatedType right = node->child2()->prediction();
@@ -320,21 +306,8 @@
}
break;
}
-
- case ArithDiv: {
- SpeculatedType left = node->child1()->prediction();
- SpeculatedType right = node->child2()->prediction();
-
- if (left && right) {
- if (Node::shouldSpeculateInt32OrBooleanForArithmetic(node->child1().node(), node->child2().node())
- && node->canSpeculateInt32(m_pass))
- changed |= mergePrediction(SpecInt32);
- else
- changed |= mergePrediction(SpecBytecodeDouble);
- }
- break;
- }
-
+
+ case ArithDiv:
case ArithMod: {
SpeculatedType left = node->child1()->prediction();
SpeculatedType right = node->child2()->prediction();
@@ -595,22 +568,13 @@
changed |= setPrediction(SpecInt32);
break;
}
- case HasGenericProperty: {
- changed |= setPrediction(SpecBoolean);
- break;
- }
- case HasStructureProperty: {
- changed |= setPrediction(SpecBoolean);
- break;
- }
+ case HasGenericProperty:
+ case HasStructureProperty:
case HasIndexedProperty: {
changed |= setPrediction(SpecBoolean);
break;
}
- case GetStructurePropertyEnumerator: {
- changed |= setPrediction(SpecCell);
- break;
- }
+ case GetStructurePropertyEnumerator:
case GetGenericPropertyEnumerator: {
changed |= setPrediction(SpecCell);
break;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
