Title: [179816] trunk/Source/_javascript_Core
Revision
179816
Author
[email protected]
Date
2015-02-08 18:40:09 -0800 (Sun, 08 Feb 2015)

Log Message

Remove useless declarations and a stale comment from DFGByteCodeParser.h
https://bugs.webkit.org/show_bug.cgi?id=141361

Reviewed by Darin Adler.

The comment refers to the original form of the ByteCodeParser:
    parse(Graph&, JSGlobalData*, CodeBlock*, unsigned startIndex);

That form is long dead, the comment is more misleading than anything.

* dfg/DFGByteCodeParser.cpp:
* dfg/DFGByteCodeParser.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (179815 => 179816)


--- trunk/Source/_javascript_Core/ChangeLog	2015-02-09 02:38:47 UTC (rev 179815)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-02-09 02:40:09 UTC (rev 179816)
@@ -1,5 +1,20 @@
 2015-02-08  Benjamin Poulain  <[email protected]>
 
+        Remove useless declarations and a stale comment from DFGByteCodeParser.h
+        https://bugs.webkit.org/show_bug.cgi?id=141361
+
+        Reviewed by Darin Adler.
+
+        The comment refers to the original form of the ByteCodeParser:
+            parse(Graph&, JSGlobalData*, CodeBlock*, unsigned startIndex);
+
+        That form is long dead, the comment is more misleading than anything.
+
+        * dfg/DFGByteCodeParser.cpp:
+        * dfg/DFGByteCodeParser.h:
+
+2015-02-08  Benjamin Poulain  <[email protected]>
+
         Encapsulate DFG::Plan's beforeFTL timestamp
         https://bugs.webkit.org/show_bug.cgi?id=141360
 

Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (179815 => 179816)


--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2015-02-09 02:38:47 UTC (rev 179815)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2015-02-09 02:40:09 UTC (rev 179816)
@@ -35,6 +35,7 @@
 #include "CodeBlockWithJITType.h"
 #include "DFGArrayMode.h"
 #include "DFGCapabilities.h"
+#include "DFGGraph.h"
 #include "DFGJITCode.h"
 #include "GetByIdStatus.h"
 #include "Heap.h"

Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.h (179815 => 179816)


--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.h	2015-02-09 02:38:47 UTC (rev 179815)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.h	2015-02-09 02:40:09 UTC (rev 179816)
@@ -28,17 +28,10 @@
 
 #if ENABLE(DFG_JIT)
 
-#include "DFGGraph.h"
+namespace JSC { namespace DFG {
 
-namespace JSC {
+class Graph;
 
-class CodeBlock;
-class VM;
-
-namespace DFG {
-
-// Populate the Graph with a basic block of code from the CodeBlock,
-// starting at the provided bytecode index.
 bool parse(Graph&);
 
 } } // namespace JSC::DFG
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to