Title: [182172] trunk/Source/WebKit2
- Revision
- 182172
- Author
- [email protected]
- Date
- 2015-03-30 20:02:41 -0700 (Mon, 30 Mar 2015)
Log Message
WebBackForwardList doesn't need to manually clear the snapshot of an entry when removing it.
<https://webkit.org/b/143231>
Reviewed by Tim Horton.
Now that we don't keep WebBackForwardListItem objects alive forever, it's not necessary
to clear the snapshot when removing them from the WebBackForwardList, since the entire
object will be deleted shortly after that anyway.
* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::didRemoveItem):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (182171 => 182172)
--- trunk/Source/WebKit2/ChangeLog 2015-03-31 01:59:31 UTC (rev 182171)
+++ trunk/Source/WebKit2/ChangeLog 2015-03-31 03:02:41 UTC (rev 182172)
@@ -1,3 +1,17 @@
+2015-03-30 Andreas Kling <[email protected]>
+
+ WebBackForwardList doesn't need to manually clear the snapshot of an entry when removing it.
+ <https://webkit.org/b/143231>
+
+ Reviewed by Tim Horton.
+
+ Now that we don't keep WebBackForwardListItem objects alive forever, it's not necessary
+ to clear the snapshot when removing them from the WebBackForwardList, since the entire
+ object will be deleted shortly after that anyway.
+
+ * UIProcess/WebBackForwardList.cpp:
+ (WebKit::WebBackForwardList::didRemoveItem):
+
2015-03-30 Enrica Casucci <[email protected]>
[iOS] WebContent crashing at WebCore: WebCore::Range::collectSelectionRects.
Modified: trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp (182171 => 182172)
--- trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp 2015-03-31 01:59:31 UTC (rev 182171)
+++ trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp 2015-03-31 03:02:41 UTC (rev 182172)
@@ -437,10 +437,6 @@
void WebBackForwardList::didRemoveItem(WebBackForwardListItem& backForwardListItem)
{
m_page->backForwardRemovedItem(backForwardListItem.itemID());
-
-#if PLATFORM(COCOA)
- backForwardListItem.setSnapshot(nullptr);
-#endif
}
} // namespace WebKit
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
