Title: [182173] trunk/Source/WebKit2
- Revision
- 182173
- Author
- [email protected]
- Date
- 2015-03-30 20:27:01 -0700 (Mon, 30 Mar 2015)
Log Message
Unreviewed, rolling out r182172.
https://bugs.webkit.org/show_bug.cgi?id=143250
Since this class is an API object, we don't know for sure when
it will be destroyed. (Requested by kling on #webkit).
Reverted changeset:
"WebBackForwardList doesn't need to manually clear the
snapshot of an entry when removing it."
https://bugs.webkit.org/show_bug.cgi?id=143231
http://trac.webkit.org/changeset/182172
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (182172 => 182173)
--- trunk/Source/WebKit2/ChangeLog 2015-03-31 03:02:41 UTC (rev 182172)
+++ trunk/Source/WebKit2/ChangeLog 2015-03-31 03:27:01 UTC (rev 182173)
@@ -1,3 +1,18 @@
+2015-03-30 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r182172.
+ https://bugs.webkit.org/show_bug.cgi?id=143250
+
+ Since this class is an API object, we don't know for sure when
+ it will be destroyed. (Requested by kling on #webkit).
+
+ Reverted changeset:
+
+ "WebBackForwardList doesn't need to manually clear the
+ snapshot of an entry when removing it."
+ https://bugs.webkit.org/show_bug.cgi?id=143231
+ http://trac.webkit.org/changeset/182172
+
2015-03-30 Andreas Kling <[email protected]>
WebBackForwardList doesn't need to manually clear the snapshot of an entry when removing it.
Modified: trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp (182172 => 182173)
--- trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp 2015-03-31 03:02:41 UTC (rev 182172)
+++ trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp 2015-03-31 03:27:01 UTC (rev 182173)
@@ -437,6 +437,10 @@
void WebBackForwardList::didRemoveItem(WebBackForwardListItem& backForwardListItem)
{
m_page->backForwardRemovedItem(backForwardListItem.itemID());
+
+#if PLATFORM(COCOA)
+ backForwardListItem.setSnapshot(nullptr);
+#endif
}
} // namespace WebKit
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
