Title: [182184] trunk/Websites/perf.webkit.org
- Revision
- 182184
- Author
- [email protected]
- Date
- 2015-03-31 10:16:07 -0700 (Tue, 31 Mar 2015)
Log Message
REGRESSION(r180000): Changing moving average or enveloping strategy doesn't update the graph
https://bugs.webkit.org/show_bug.cgi?id=143254
Reviewed by Antti Koivisto.
The bug was caused by App.Pane no longer replacing 'chartData' property when updating the moving average
or the enveloping values. Fixed the bug by creating a new chartData object when the strategy is changed
so that the interactive chart component will observe a change to 'chartData'.
* public/v2/app.js:
(App.Pane._movingAverageOrEnvelopeStrategyDidChange): Added.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (182183 => 182184)
--- trunk/Websites/perf.webkit.org/ChangeLog 2015-03-31 12:35:25 UTC (rev 182183)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-03-31 17:16:07 UTC (rev 182184)
@@ -1,3 +1,17 @@
+2015-03-31 Ryosuke Niwa <[email protected]>
+
+ REGRESSION(r180000): Changing moving average or enveloping strategy doesn't update the graph
+ https://bugs.webkit.org/show_bug.cgi?id=143254
+
+ Reviewed by Antti Koivisto.
+
+ The bug was caused by App.Pane no longer replacing 'chartData' property when updating the moving average
+ or the enveloping values. Fixed the bug by creating a new chartData object when the strategy is changed
+ so that the interactive chart component will observe a change to 'chartData'.
+
+ * public/v2/app.js:
+ (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Added.
+
2015-03-19 Ryosuke Niwa <[email protected]>
Unreviewed build fixes.
Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (182183 => 182184)
--- trunk/Websites/perf.webkit.org/public/v2/app.js 2015-03-31 12:35:25 UTC (rev 182183)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2015-03-31 17:16:07 UTC (rev 182184)
@@ -500,6 +500,18 @@
this._updateStrategyConfigIfNeeded(envelopingStrategy, 'envelopingConfig');
chartData.movingAverage = this._computeMovingAverageAndOutliers(chartData, movingAverageStrategy, envelopingStrategy);
+ },
+ _movingAverageOrEnvelopeStrategyDidChange: function () {
+ this._updateMovingAverageAndEnvelope();
+
+ var newChartData = {};
+ var chartData = this.get('chartData');
+ if (!chartData)
+ return;
+ for (var property in chartData)
+ newChartData[property] = chartData[property];
+ this.set('chartData', newChartData);
+
}.observes('chosenMovingAverageStrategy', '[email protected]',
'chosenEnvelopingStrategy', '[email protected]'),
_computeMovingAverageAndOutliers: function (chartData, movingAverageStrategy, envelopingStrategy)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
