Title: [182185] trunk/Websites/perf.webkit.org
- Revision
- 182185
- Author
- [email protected]
- Date
- 2015-03-31 10:17:07 -0700 (Tue, 31 Mar 2015)
Log Message
Perf dashboard should show relative change in values
https://bugs.webkit.org/show_bug.cgi?id=143252
Reviewed by Antti Koivisto.
When a range of values are selected, show the percentage difference between the start and the end
in addition to the absolute value difference. When a single point is selected, show the relative
difference with respect to the previous point. Use two significant figures and always show plus sign
when the difference is positive.
* public/v2/app.js: Compute and format the relative difference.
* public/v2/chart-pane.css: Don't let commits view shrink itself when they're all collapsed.
* public/v2/index.html: Show the relative difference.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (182184 => 182185)
--- trunk/Websites/perf.webkit.org/ChangeLog 2015-03-31 17:16:07 UTC (rev 182184)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-03-31 17:17:07 UTC (rev 182185)
@@ -1,5 +1,21 @@
2015-03-31 Ryosuke Niwa <[email protected]>
+ Perf dashboard should show relative change in values
+ https://bugs.webkit.org/show_bug.cgi?id=143252
+
+ Reviewed by Antti Koivisto.
+
+ When a range of values are selected, show the percentage difference between the start and the end
+ in addition to the absolute value difference. When a single point is selected, show the relative
+ difference with respect to the previous point. Use two significant figures and always show plus sign
+ when the difference is positive.
+
+ * public/v2/app.js: Compute and format the relative difference.
+ * public/v2/chart-pane.css: Don't let commits view shrink itself when they're all collapsed.
+ * public/v2/index.html: Show the relative difference.
+
+2015-03-31 Ryosuke Niwa <[email protected]>
+
REGRESSION(r180000): Changing moving average or enveloping strategy doesn't update the graph
https://bugs.webkit.org/show_bug.cgi?id=143254
Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (182184 => 182185)
--- trunk/Websites/perf.webkit.org/public/v2/app.js 2015-03-31 17:16:07 UTC (rev 182184)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2015-03-31 17:17:07 UTC (rev 182185)
@@ -424,7 +424,13 @@
label = formatter(Math.abs(diffFromTarget)) + ' until target';
var valueDelta = previousPoint ? chartData.deltaFormatter(currentPoint.value - previousPoint.value) : null;
- return {className: className, label: label, currentValue: chartData.formatter(currentPoint.value), valueDelta: valueDelta};
+ return {
+ className: className,
+ label: label,
+ currentValue: chartData.formatter(currentPoint.value),
+ valueDelta: valueDelta,
+ relativeDelta: d3.format('+.2p')((currentPoint.value - previousPoint.value) / previousPoint.value),
+ };
},
_relativeDifferentToLaterPointInTimeSeries: function (currentPoint, timeSeries)
{
Modified: trunk/Websites/perf.webkit.org/public/v2/chart-pane.css (182184 => 182185)
--- trunk/Websites/perf.webkit.org/public/v2/chart-pane.css 2015-03-31 17:16:07 UTC (rev 182184)
+++ trunk/Websites/perf.webkit.org/public/v2/chart-pane.css 2015-03-31 17:17:07 UTC (rev 182185)
@@ -241,6 +241,10 @@
border-collapse: collapse;
}
+.chart-pane .commits-viewer {
+ width: 100%;
+}
+
.chart-pane .details-table td:last-child {
padding-right: 1px;
}
Modified: trunk/Websites/perf.webkit.org/public/v2/index.html (182184 => 182185)
--- trunk/Websites/perf.webkit.org/public/v2/index.html 2015-03-31 17:16:07 UTC (rev 182184)
+++ trunk/Websites/perf.webkit.org/public/v2/index.html 2015-03-31 17:17:07 UTC (rev 182185)
@@ -270,7 +270,7 @@
<td>
{{details.status.currentValue}} {{chartData.unit}}
{{#if details.status.valueDelta}}
- ({{details.status.valueDelta}} {{chartData.unit}})
+ ({{details.status.valueDelta}} {{chartData.unit}} / {{details.status.relativeDelta}})
{{/if}}
{{#if details.status.label}}
<br>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
