Title: [182585] trunk/Source/WebCore
- Revision
- 182585
- Author
- [email protected]
- Date
- 2015-04-08 20:44:44 -0700 (Wed, 08 Apr 2015)
Log Message
Add a debug assertion that will fire if we try to paint layer contents on a background thread
https://bugs.webkit.org/show_bug.cgi?id=143547
Reviewed by Alexey Proskuryakov.
New assertion to catch cases where other frameworks erroneously trigger painting
on a non-main (or non-Web) thread.
* platform/graphics/mac/WebLayer.mm:
(-[WebSimpleLayer display]):
(-[WebSimpleLayer drawInContext:]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (182584 => 182585)
--- trunk/Source/WebCore/ChangeLog 2015-04-09 03:42:04 UTC (rev 182584)
+++ trunk/Source/WebCore/ChangeLog 2015-04-09 03:44:44 UTC (rev 182585)
@@ -1,3 +1,17 @@
+2015-04-08 Simon Fraser <[email protected]>
+
+ Add a debug assertion that will fire if we try to paint layer contents on a background thread
+ https://bugs.webkit.org/show_bug.cgi?id=143547
+
+ Reviewed by Alexey Proskuryakov.
+
+ New assertion to catch cases where other frameworks erroneously trigger painting
+ on a non-main (or non-Web) thread.
+
+ * platform/graphics/mac/WebLayer.mm:
+ (-[WebSimpleLayer display]):
+ (-[WebSimpleLayer drawInContext:]):
+
2015-04-08 Brent Fulgham <[email protected]>
[Mac] WebKit is not honoring OS preferences for secondary click behaviors
Modified: trunk/Source/WebCore/platform/graphics/mac/WebLayer.mm (182584 => 182585)
--- trunk/Source/WebCore/platform/graphics/mac/WebLayer.mm 2015-04-09 03:42:04 UTC (rev 182584)
+++ trunk/Source/WebCore/platform/graphics/mac/WebLayer.mm 2015-04-09 03:44:44 UTC (rev 182585)
@@ -107,6 +107,7 @@
if (pthread_main_np())
WebThreadLock();
#endif
+ ASSERT(isMainThread());
[super display];
PlatformCALayer* layer = PlatformCALayer::platformCALayer(self);
if (layer && layer->owner())
@@ -119,6 +120,7 @@
if (pthread_main_np())
WebThreadLock();
#endif
+ ASSERT(isMainThread());
PlatformCALayer* layer = PlatformCALayer::platformCALayer(self);
if (layer && layer->owner()) {
GraphicsContext graphicsContext(context);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
