Title: [182584] trunk/Tools
- Revision
- 182584
- Author
- [email protected]
- Date
- 2015-04-08 20:42:04 -0700 (Wed, 08 Apr 2015)
Log Message
[Mac] Unreviewed test fix after r182581
The behavior of control-left-click is controlled by a system preference.
Our test bots have this turned off.
* TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (182583 => 182584)
--- trunk/Tools/ChangeLog 2015-04-09 03:21:46 UTC (rev 182583)
+++ trunk/Tools/ChangeLog 2015-04-09 03:42:04 UTC (rev 182584)
@@ -1,5 +1,17 @@
2015-04-08 Brent Fulgham <[email protected]>
+ [Mac] Unreviewed test fix after r182581
+
+ The behavior of control-left-click is controlled by a system preference.
+ Our test bots have this turned off.
+
+ * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
+ (TestWebKitAPI::TEST):
+ * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
+ (TestWebKitAPI::TEST):
+
+2015-04-08 Brent Fulgham <[email protected]>
+
[Mac] WebKit is not honoring OS preferences for secondary click behaviors
https://bugs.webkit.org/show_bug.cgi?id=143452
<rdar://problem/20437483>
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp (182583 => 182584)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp 2015-04-09 03:21:46 UTC (rev 182583)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp 2015-04-09 03:42:04 UTC (rev 182584)
@@ -86,7 +86,8 @@
TEST(WebKit2, MenuAndButtonForControlLeftClick)
{
- buildAndPerformTest(kWKEventMouseButtonLeftButton, kWKEventModifiersControlKey, "0", "context");
+ // Note: This is controlled by a Mouse system preference. Check settings if this is failing.
+ buildAndPerformTest(kWKEventMouseButtonLeftButton, kWKEventModifiersControlKey, "0", "none");
}
TEST(WebKit2, MenuAndButtonForControlRightClick)
Modified: trunk/Tools/TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm (182583 => 182584)
--- trunk/Tools/TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm 2015-04-09 03:21:46 UTC (rev 182583)
+++ trunk/Tools/TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm 2015-04-09 03:42:04 UTC (rev 182584)
@@ -78,7 +78,8 @@
TEST(WebKit1, MenuAndButtonForControlLeftClick)
{
- buildAndPerformTest(NSLeftMouseDown, NSControlKeyMask, WebCore::LeftButton, NSMenuTypeContextMenu);
+ // Note: This is controlled by a Mouse system preference. Check settings if this is failing.
+ buildAndPerformTest(NSLeftMouseDown, NSControlKeyMask, WebCore::LeftButton, NSMenuTypeNone);
}
TEST(WebKit1, MenuAndButtonForControlRightClick)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
