Title: [183227] trunk/Source/WebCore
- Revision
- 183227
- Author
- [email protected]
- Date
- 2015-04-23 16:13:01 -0700 (Thu, 23 Apr 2015)
Log Message
Yellow highlight has gray background color when invoking Lookup on an address in a Google Maps drop down
https://bugs.webkit.org/show_bug.cgi?id=138737
<rdar://problem/18904429>
Reviewed by Simon Fraser.
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
Other RenderObjects don't paint box decorations in the selection painting phase,
so RenderReplaced probably shouldn't either. This fixes the case where, when doing
selection-only painting of a bit of text over top of a RenderReplaced, the RenderReplaced
would paint its background, filling the previously transparent bitmap with an unwanted color.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (183226 => 183227)
--- trunk/Source/WebCore/ChangeLog 2015-04-23 23:04:40 UTC (rev 183226)
+++ trunk/Source/WebCore/ChangeLog 2015-04-23 23:13:01 UTC (rev 183227)
@@ -1,3 +1,18 @@
+2015-04-23 Tim Horton <[email protected]>
+
+ Yellow highlight has gray background color when invoking Lookup on an address in a Google Maps drop down
+ https://bugs.webkit.org/show_bug.cgi?id=138737
+ <rdar://problem/18904429>
+
+ Reviewed by Simon Fraser.
+
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::paint):
+ Other RenderObjects don't paint box decorations in the selection painting phase,
+ so RenderReplaced probably shouldn't either. This fixes the case where, when doing
+ selection-only painting of a bit of text over top of a RenderReplaced, the RenderReplaced
+ would paint its background, filling the previously transparent bitmap with an unwanted color.
+
2015-04-23 Roger Fong <[email protected]>
Update media timeline controls when video is paused..
Modified: trunk/Source/WebCore/rendering/RenderReplaced.cpp (183226 => 183227)
--- trunk/Source/WebCore/rendering/RenderReplaced.cpp 2015-04-23 23:04:40 UTC (rev 183226)
+++ trunk/Source/WebCore/rendering/RenderReplaced.cpp 2015-04-23 23:13:01 UTC (rev 183227)
@@ -142,7 +142,7 @@
LayoutPoint adjustedPaintOffset = paintOffset + location();
- if (hasBoxDecorations() && (paintInfo.phase == PaintPhaseForeground || paintInfo.phase == PaintPhaseSelection))
+ if (hasBoxDecorations() && paintInfo.phase == PaintPhaseForeground)
paintBoxDecorations(paintInfo, adjustedPaintOffset);
if (paintInfo.phase == PaintPhaseMask) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
