Title: [183228] trunk/Source/WebKit2
- Revision
- 183228
- Author
- [email protected]
- Date
- 2015-04-23 16:18:03 -0700 (Thu, 23 Apr 2015)
Log Message
Quick Look preview popover is not dismissed on scroll in Mail
https://bugs.webkit.org/show_bug.cgi?id=144119
<rdar://problem/19752045>
Reviewed by Anders Carlsson.
* UIProcess/API/mac/WKView.mm:
(-[WKView renewGState]):
If we have a TextIndicator, dismiss all content relative child windows
on renewGState, not just the TextIndicator itself.
This will fix cases like Mail, where WebKit isn't driving the scrolling,
and we have no way (except renewGState) to know that scrolling is happening.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (183227 => 183228)
--- trunk/Source/WebKit2/ChangeLog 2015-04-23 23:13:01 UTC (rev 183227)
+++ trunk/Source/WebKit2/ChangeLog 2015-04-23 23:18:03 UTC (rev 183228)
@@ -1,3 +1,19 @@
+2015-04-23 Tim Horton <[email protected]>
+
+ Quick Look preview popover is not dismissed on scroll in Mail
+ https://bugs.webkit.org/show_bug.cgi?id=144119
+ <rdar://problem/19752045>
+
+ Reviewed by Anders Carlsson.
+
+ * UIProcess/API/mac/WKView.mm:
+ (-[WKView renewGState]):
+ If we have a TextIndicator, dismiss all content relative child windows
+ on renewGState, not just the TextIndicator itself.
+
+ This will fix cases like Mail, where WebKit isn't driving the scrolling,
+ and we have no way (except renewGState) to know that scrolling is happening.
+
2015-04-23 Simon Fraser <[email protected]>
Changing TiledBacking velocity should schedule a tile revalidation
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (183227 => 183228)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-04-23 23:13:01 UTC (rev 183227)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-04-23 23:18:03 UTC (rev 183228)
@@ -601,8 +601,8 @@
- (void)renewGState
{
- // Hide the find indicator.
- _data->_textIndicatorWindow = nullptr;
+ if (_data->_textIndicatorWindow)
+ [self _dismissContentRelativeChildWindows];
// Update the view frame.
if ([self window])
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
