Title: [183630] trunk/Source/_javascript_Core
- Revision
- 183630
- Author
- [email protected]
- Date
- 2015-04-30 10:40:31 -0700 (Thu, 30 Apr 2015)
Log Message
Add a comment clarifying the behavior and semantics of getCallData/getConstructData, in
particular that they cannot change their minds and may be called from compiler threads.
Rubber stamped by Geoffrey Garen.
* runtime/JSCell.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (183629 => 183630)
--- trunk/Source/_javascript_Core/ChangeLog 2015-04-30 17:36:26 UTC (rev 183629)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-04-30 17:40:31 UTC (rev 183630)
@@ -1,3 +1,12 @@
+2015-04-30 Filip Pizlo <[email protected]>
+
+ Add a comment clarifying the behavior and semantics of getCallData/getConstructData, in
+ particular that they cannot change their minds and may be called from compiler threads.
+
+ Rubber stamped by Geoffrey Garen.
+
+ * runtime/JSCell.h:
+
2015-04-29 Filip Pizlo <[email protected]>
DFG Is<Blah> versions of TypeOf should fold based on proven input type
Modified: trunk/Source/_javascript_Core/runtime/JSCell.h (183629 => 183630)
--- trunk/Source/_javascript_Core/runtime/JSCell.h 2015-04-30 17:36:26 UTC (rev 183629)
+++ trunk/Source/_javascript_Core/runtime/JSCell.h 2015-04-30 17:40:31 UTC (rev 183630)
@@ -112,6 +112,12 @@
JS_EXPORT_PRIVATE JSObject* getObject(); // NULL if not an object
const JSObject* getObject() const; // NULL if not an object
+ // Returns information about how to call/construct this cell as a function/constructor. May tell
+ // you that the cell is not callable or constructor (default is that it's not either). If it
+ // says that the function is callable, and the TypeOfShouldCallGetCallData type flag is set, and
+ // this is an object, then typeof will return "function" instead of "object". These methods
+ // cannot change their minds and must be thread-safe. They are sometimes called from compiler
+ // threads.
JS_EXPORT_PRIVATE static CallType getCallData(JSCell*, CallData&);
JS_EXPORT_PRIVATE static ConstructType getConstructData(JSCell*, ConstructData&);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
