Title: [183631] trunk/Source/_javascript_Core
- Revision
- 183631
- Author
- [email protected]
- Date
- 2015-04-30 10:44:23 -0700 (Thu, 30 Apr 2015)
Log Message
Unreviewed, add a FIXME comment referencing https://bugs.webkit.org/show_bug.cgi?id=144458.
* jit/JITOperations.cpp:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (183630 => 183631)
--- trunk/Source/_javascript_Core/ChangeLog 2015-04-30 17:40:31 UTC (rev 183630)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-04-30 17:44:23 UTC (rev 183631)
@@ -1,5 +1,11 @@
2015-04-30 Filip Pizlo <[email protected]>
+ Unreviewed, add a FIXME comment referencing https://bugs.webkit.org/show_bug.cgi?id=144458.
+
+ * jit/JITOperations.cpp:
+
+2015-04-30 Filip Pizlo <[email protected]>
+
Add a comment clarifying the behavior and semantics of getCallData/getConstructData, in
particular that they cannot change their minds and may be called from compiler threads.
Modified: trunk/Source/_javascript_Core/jit/JITOperations.cpp (183630 => 183631)
--- trunk/Source/_javascript_Core/jit/JITOperations.cpp 2015-04-30 17:40:31 UTC (rev 183630)
+++ trunk/Source/_javascript_Core/jit/JITOperations.cpp 2015-04-30 17:44:23 UTC (rev 183631)
@@ -721,8 +721,12 @@
JSValue calleeAsValue = execCallee->calleeAsValue();
JSCell* calleeAsFunctionCell = getJSFunction(calleeAsValue);
- if (!calleeAsFunctionCell)
+ if (!calleeAsFunctionCell) {
+ // FIXME: We should cache these kinds of calls. They can be common and currently they are
+ // expensive.
+ // https://bugs.webkit.org/show_bug.cgi?id=144458
return reinterpret_cast<char*>(handleHostCall(execCallee, calleeAsValue, kind));
+ }
JSFunction* callee = jsCast<JSFunction*>(calleeAsFunctionCell);
JSScope* scope = callee->scopeUnchecked();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
