Title: [183740] trunk/Source
- Revision
- 183740
- Author
- [email protected]
- Date
- 2015-05-04 01:42:28 -0700 (Mon, 04 May 2015)
Log Message
[ARM] Don't compare unsigned chars to EOF (-1)
https://bugs.webkit.org/show_bug.cgi?id=144439
Reviewed by Geoffrey Garen.
Source/WebCore:
* platform/linux/MemoryPressureHandlerLinux.cpp:
(WebKit::nextToken): Don't cast return value of fgetc() to char.
Source/WebKit2:
* Shared/linux/WebMemorySamplerLinux.cpp:
(WebKit::nextToken): Don't cast return value of fgetc() to char.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (183739 => 183740)
--- trunk/Source/WebCore/ChangeLog 2015-05-04 08:37:03 UTC (rev 183739)
+++ trunk/Source/WebCore/ChangeLog 2015-05-04 08:42:28 UTC (rev 183740)
@@ -1,3 +1,13 @@
+2015-05-04 Csaba Osztrogonác <[email protected]>
+
+ [ARM] Don't compare unsigned chars to EOF (-1)
+ https://bugs.webkit.org/show_bug.cgi?id=144439
+
+ Reviewed by Geoffrey Garen.
+
+ * platform/linux/MemoryPressureHandlerLinux.cpp:
+ (WebKit::nextToken): Don't cast return value of fgetc() to char.
+
2015-05-04 Manuel Rego Casasnovas <[email protected]>
[CSS Grid Layout] Wrong computed style for named grid lines in implicit tracks
Modified: trunk/Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp (183739 => 183740)
--- trunk/Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp 2015-05-04 08:37:03 UTC (rev 183739)
+++ trunk/Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp 2015-05-04 08:42:28 UTC (rev 183740)
@@ -65,7 +65,7 @@
char buffer[bufferSize] = {0, };
unsigned index = 0;
while (index < bufferSize) {
- char ch = fgetc(file);
+ int ch = fgetc(file);
if (ch == EOF || (isASCIISpace(ch) && index)) // Break on non-initial ASCII space.
break;
if (!isASCIISpace(ch)) {
Modified: trunk/Source/WebKit2/ChangeLog (183739 => 183740)
--- trunk/Source/WebKit2/ChangeLog 2015-05-04 08:37:03 UTC (rev 183739)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-04 08:42:28 UTC (rev 183740)
@@ -1,3 +1,13 @@
+2015-05-04 Csaba Osztrogonác <[email protected]>
+
+ [ARM] Don't compare unsigned chars to EOF (-1)
+ https://bugs.webkit.org/show_bug.cgi?id=144439
+
+ Reviewed by Geoffrey Garen.
+
+ * Shared/linux/WebMemorySamplerLinux.cpp:
+ (WebKit::nextToken): Don't cast return value of fgetc() to char.
+
2015-05-04 Antti Koivisto <[email protected]>
Remove NetworkResourceLoadScheduler
Modified: trunk/Source/WebKit2/Shared/linux/WebMemorySamplerLinux.cpp (183739 => 183740)
--- trunk/Source/WebKit2/Shared/linux/WebMemorySamplerLinux.cpp 2015-05-04 08:37:03 UTC (rev 183739)
+++ trunk/Source/WebKit2/Shared/linux/WebMemorySamplerLinux.cpp 2015-05-04 08:42:28 UTC (rev 183740)
@@ -66,7 +66,7 @@
char buffer[maxBuffer] = {0, };
unsigned int index = 0;
while (index < maxBuffer) {
- char ch = fgetc(file);
+ int ch = fgetc(file);
if (ch == EOF || (isASCIISpace(ch) && index)) // Break on non-initial ASCII space.
break;
if (!isASCIISpace(ch)) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
