Title: [183741] trunk
Revision
183741
Author
[email protected]
Date
2015-05-04 01:51:25 -0700 (Mon, 04 May 2015)

Log Message

[cmake] Disable GNU Gold linker on Cortex A53
https://bugs.webkit.org/show_bug.cgi?id=144382

Reviewed by Carlos Garcia Campos.

* Source/cmake/OptionsCommon.cmake:

Modified Paths

Diff

Modified: trunk/ChangeLog (183740 => 183741)


--- trunk/ChangeLog	2015-05-04 08:42:28 UTC (rev 183740)
+++ trunk/ChangeLog	2015-05-04 08:51:25 UTC (rev 183741)
@@ -1,3 +1,12 @@
+2015-05-04  Csaba Osztrogonác  <[email protected]>
+
+        [cmake] Disable GNU Gold linker on Cortex A53
+        https://bugs.webkit.org/show_bug.cgi?id=144382
+
+        Reviewed by Carlos Garcia Campos.
+
+        * Source/cmake/OptionsCommon.cmake:
+
 2015-05-01  Martin Robinson  <[email protected]>
 
         USE(...) macro should expect unprefixed variables

Modified: trunk/Source/cmake/OptionsCommon.cmake (183740 => 183741)


--- trunk/Source/cmake/OptionsCommon.cmake	2015-05-04 08:42:28 UTC (rev 183740)
+++ trunk/Source/cmake/OptionsCommon.cmake	2015-05-04 08:51:25 UTC (rev 183741)
@@ -61,14 +61,16 @@
     if (CXX_ACCEPTS_MFIX_CORTEX_A53_835769)
         set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -mfix-cortex-a53-835769")
         set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mfix-cortex-a53-835769")
-        message(STATUS "Enabling Cortex-A53 workaround for compiler")
+        message(STATUS "Enabling Cortex-A53 workaround for compiler and disabling GNU gold linker, because it doesn't support this workaround.")
     endif ()
 endif ()
 
 EXPOSE_VARIABLE_TO_BUILD(WTF_CPU_ARM64_CORTEXA53)
 
 # Use ld.gold if it is available and isn't disabled explicitly
-option(USE_LD_GOLD "Use GNU gold linker" ON)
+include(CMakeDependentOption)
+CMAKE_DEPENDENT_OPTION(USE_LD_GOLD "Use GNU gold linker" ON
+                       "NOT CXX_ACCEPTS_MFIX_CORTEX_A53_835769" OFF)
 if (USE_LD_GOLD)
     execute_process(COMMAND ${CMAKE_C_COMPILER} -fuse-ld=gold -Wl,--version ERROR_QUIET OUTPUT_VARIABLE LD_VERSION)
     if ("${LD_VERSION}" MATCHES "GNU gold")
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to