Title: [183796] trunk/Tools
- Revision
- 183796
- Author
- [email protected]
- Date
- 2015-05-04 22:22:52 -0700 (Mon, 04 May 2015)
Log Message
Correct '--show-webview' option for Tiled Drawing tests
https://bugs.webkit.org/show_bug.cgi?id=144621
Reviewed by Simon Fraser.
The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (183795 => 183796)
--- trunk/Tools/ChangeLog 2015-05-05 04:49:00 UTC (rev 183795)
+++ trunk/Tools/ChangeLog 2015-05-05 05:22:52 UTC (rev 183796)
@@ -1,3 +1,17 @@
+2015-05-04 Brent Fulgham <[email protected]>
+
+ Correct '--show-webview' option for Tiled Drawing tests
+ https://bugs.webkit.org/show_bug.cgi?id=144621
+
+ Reviewed by Simon Fraser.
+
+ The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
+ sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
+
+ * WebKitTestRunner/mac/TestControllerMac.mm:
+ (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
+ WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
+
2015-05-04 Filip Pizlo <[email protected]>
Large array shouldn't be slow
Modified: trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm (183795 => 183796)
--- trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm 2015-05-05 04:49:00 UTC (rev 183795)
+++ trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm 2015-05-05 05:22:52 UTC (rev 183796)
@@ -107,6 +107,10 @@
auto useRemoteLayerTreeValue = adoptWK(WKBooleanCreate(shouldUseRemoteLayerTree()));
WKDictionarySetItem(viewOptions.get(), useRemoteLayerTreeKey.get(), useRemoteLayerTreeValue.get());
+ auto shouldShowWebViewKey = adoptWK(WKStringCreateWithUTF8CString("ShouldShowWebView"));
+ auto shouldShowWebViewValue = adoptWK(WKBooleanCreate(shouldShowWebView()));
+ WKDictionarySetItem(viewOptions.get(), shouldShowWebViewKey.get(), shouldShowWebViewValue.get());
+
ensureViewSupportsOptions(viewOptions.get());
if (!test.urlContains("contentextensions/"))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
