Title: [183797] trunk/Source/WebCore
Revision
183797
Author
[email protected]
Date
2015-05-04 23:57:27 -0700 (Mon, 04 May 2015)

Log Message

[iOS] Videos on apple.com flash when touching to show or hide the controls
https://bugs.webkit.org/show_bug.cgi?id=144598

Reviewed by Eric Carlson.

The apple.com site will add a "selection" rectangle atop a playing video when it recieves a touchstart
event. The default media controls use touchstart to signal the controls to become visible. Stop the touch
from propagating down to the page in this case.

* Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.handleWrapperTouchStart):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (183796 => 183797)


--- trunk/Source/WebCore/ChangeLog	2015-05-05 05:22:52 UTC (rev 183796)
+++ trunk/Source/WebCore/ChangeLog	2015-05-05 06:57:27 UTC (rev 183797)
@@ -1,3 +1,17 @@
+2015-05-04  Jer Noble  <[email protected]>
+
+        [iOS] Videos on apple.com flash when touching to show or hide the controls
+        https://bugs.webkit.org/show_bug.cgi?id=144598
+
+        Reviewed by Eric Carlson.
+
+        The apple.com site will add a "selection" rectangle atop a playing video when it recieves a touchstart
+        event. The default media controls use touchstart to signal the controls to become visible. Stop the touch
+        from propagating down to the page in this case.
+
+        * Modules/mediacontrols/mediaControlsiOS.js:
+        (ControllerIOS.prototype.handleWrapperTouchStart):
+
 2015-05-04  Andreas Kling  <[email protected]>
 
         Record the reference time when Performance is constructed.

Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js (183796 => 183797)


--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js	2015-05-05 05:22:52 UTC (rev 183796)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js	2015-05-05 06:57:27 UTC (rev 183797)
@@ -381,6 +381,8 @@
             this.hideTimer = setTimeout(this.hideControls.bind(this), this.HideControlsDelay);
         } else if (!this.canPlay())
             this.hideControls();
+
+        return true;
     },
 
     handlePanelTouchStart: function(event) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to