Title: [183851] trunk/Source/_javascript_Core
- Revision
- 183851
- Author
- [email protected]
- Date
- 2015-05-05 22:52:52 -0700 (Tue, 05 May 2015)
Log Message
CopiedBlock::reportLiveBytes() should be totally cool with oversize blocks
https://bugs.webkit.org/show_bug.cgi?id=144667
Reviewed by Andreas Kling.
We are now calling this method for oversize blocks. It had an assertion that indirectly
implied that the block is not oversize, because it was claiming that the number of live
bytes should be smaller than the non-oversize-block size.
* heap/CopiedBlockInlines.h:
(JSC::CopiedBlock::reportLiveBytes):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (183850 => 183851)
--- trunk/Source/_javascript_Core/ChangeLog 2015-05-06 05:39:02 UTC (rev 183850)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-05-06 05:52:52 UTC (rev 183851)
@@ -1,5 +1,19 @@
2015-05-05 Filip Pizlo <[email protected]>
+ CopiedBlock::reportLiveBytes() should be totally cool with oversize blocks
+ https://bugs.webkit.org/show_bug.cgi?id=144667
+
+ Reviewed by Andreas Kling.
+
+ We are now calling this method for oversize blocks. It had an assertion that indirectly
+ implied that the block is not oversize, because it was claiming that the number of live
+ bytes should be smaller than the non-oversize-block size.
+
+ * heap/CopiedBlockInlines.h:
+ (JSC::CopiedBlock::reportLiveBytes):
+
+2015-05-05 Filip Pizlo <[email protected]>
+
GC has trouble with pathologically large array allocations
https://bugs.webkit.org/show_bug.cgi?id=144609
Modified: trunk/Source/_javascript_Core/heap/CopiedBlockInlines.h (183850 => 183851)
--- trunk/Source/_javascript_Core/heap/CopiedBlockInlines.h 2015-05-06 05:39:02 UTC (rev 183850)
+++ trunk/Source/_javascript_Core/heap/CopiedBlockInlines.h 2015-05-06 05:52:52 UTC (rev 183851)
@@ -51,7 +51,7 @@
#endif
m_liveBytes += bytes;
checkConsistency();
- ASSERT(m_liveBytes <= CopiedBlock::blockSize);
+ ASSERT(m_liveBytes <= m_capacity);
if (isPinned())
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
