Title: [183852] trunk/Source/_javascript_Core
- Revision
- 183852
- Author
- [email protected]
- Date
- 2015-05-05 22:56:43 -0700 (Tue, 05 May 2015)
Log Message
PutGlobalVar shouldn't have an unconditional store barrier
https://bugs.webkit.org/show_bug.cgi?id=133104
Reviewed by Benjamin Poulain.
We don't need a store barrier on PutGlobalVar if the value being stored can be
speculated to not be a cell.
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (183851 => 183852)
--- trunk/Source/_javascript_Core/ChangeLog 2015-05-06 05:52:52 UTC (rev 183851)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-05-06 05:56:43 UTC (rev 183852)
@@ -1,5 +1,18 @@
2015-05-05 Filip Pizlo <[email protected]>
+ PutGlobalVar shouldn't have an unconditional store barrier
+ https://bugs.webkit.org/show_bug.cgi?id=133104
+
+ Reviewed by Benjamin Poulain.
+
+ We don't need a store barrier on PutGlobalVar if the value being stored can be
+ speculated to not be a cell.
+
+ * dfg/DFGFixupPhase.cpp:
+ (JSC::DFG::FixupPhase::fixupNode):
+
+2015-05-05 Filip Pizlo <[email protected]>
+
CopiedBlock::reportLiveBytes() should be totally cool with oversize blocks
https://bugs.webkit.org/show_bug.cgi?id=144667
Modified: trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp (183851 => 183852)
--- trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp 2015-05-06 05:52:52 UTC (rev 183851)
+++ trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp 2015-05-06 05:56:43 UTC (rev 183852)
@@ -1051,12 +1051,8 @@
Node* globalObjectNode = m_insertionSet.insertNode(
m_indexInBlock, SpecNone, JSConstant, node->origin,
OpInfo(m_graph.freeze(m_graph.globalObjectFor(node->origin.semantic))));
- // FIXME: This probably shouldn't have an unconditional barrier.
- // https://bugs.webkit.org/show_bug.cgi?id=133104
- Node* barrierNode = m_graph.addNode(
- SpecNone, StoreBarrier, m_currentNode->origin,
- Edge(globalObjectNode, KnownCellUse));
- m_insertionSet.insert(m_indexInBlock, barrierNode);
+ insertStoreBarrier(
+ m_indexInBlock, Edge(globalObjectNode, KnownCellUse), node->child1());
break;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
